Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement i18n to support French page translations #43

Closed
wants to merge 8 commits into from

Conversation

matchai
Copy link
Collaborator

@matchai matchai commented Sep 26, 2016

Heya! 👋
I've gone ahead and begun implementing i18n to take care of #1, using jekyll-multiple-languages-plugin. 🇨🇦

So far it's been smooth sailing until I realized that the checkout process is done using a widget. After reading through the docs to Tito, it doesn't look like they've got support for i18n. It looks like you can however add an html attribute to the widget to show specific tickets.

@pcuci: Would you be able to add secondary tickets of each kind with a french label as well? We can filter out the English ones on French checkout and vice-versa.

I've also gone ahead and created a Gemfile to speed up initial setup, since we are adding more than a couple dependencies. Just so we use the correct version of Jekyll, can someone confirm if the live version of the site is the one being hosted on gh-pages? If so, I'll also include pages-gem as a dependency. 💎

I'm mostly done implementing translation tags throughout the index of the site. If anyone's got any feedback or suggestions as to how this can be done in a better/simpler/faster way, please let me know! 😀

Matan Kushner added 7 commits September 25, 2016 21:20
Having a Gemfile will allow us to manage dependencies without the hastle of listing long build steps.
Moving forward it should just be `gem install bundler && bundle`.
Since we are now using the language paths, all global assets have to be referenced relative to the root to be found.
@matchai
Copy link
Collaborator Author

matchai commented Sep 26, 2016

As an added note, could one of the project managers apply for a Crowdin license? We could use the GitHub integration to have approved translations added to the project directly

@pcuci
Copy link
Member

pcuci commented Feb 10, 2017

@matchai could you rebase and resend PR please?

Does github/pages-gem#401 block us? Re: #1

@matchai
Copy link
Collaborator Author

matchai commented Feb 10, 2017

@pcuci That issue does block us as long as we don't have a CI system or a build process.
I can make us a gulp build and deploy process when I've got some free time.

@RichardLitt
Copy link
Member

@matchai Any updates on this? :)

@matchai
Copy link
Collaborator Author

matchai commented Nov 8, 2017

@RichardLitt I was waiting to get github integration approved for the build and hosting platform you had suggested at a previous nodeschool meetup (who's name I can't remember off the top of my head).

@RichardLitt
Copy link
Member

Probably Netlify?

@matchai
Copy link
Collaborator Author

matchai commented Nov 8, 2017

That's the one! Since I'm not in the nodeschool org, I don't have the ability to configure the repo with Netlify. I had sent an email at the time asking for a hand, but I guess that's now long gone.

@RichardLitt
Copy link
Member

I had sent an email at the time asking for a hand, but I guess that's now long gone.

I doubt anyone is watching the emails. Open an issue on the GitHub organization. That might help?

@ajmas
Copy link
Collaborator

ajmas commented Nov 8, 2017

I could look at a CI solution. The two I have played with recently are Travis and Circle CI, which both offer free solutions to public repos. They both have Github integrations.

@ajmas
Copy link
Collaborator

ajmas commented Nov 8, 2017

Have created issue #66 for CI support.

@ajmas
Copy link
Collaborator

ajmas commented Nov 13, 2017

Okay, went and completed the work for CI. I took the chance and made gh-pages-src the source branch for gh-pages, with Travis deploying to gh-pages branch. The changes here will need to be done agains the new branch. Hope that is okay.

@matchai matchai closed this Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants