Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StepSecurity] Apply security best practices #7278

Conversation

step-security-bot
Copy link
Contributor

Summary

This pull request is created by StepSecurity at the request of @AugustinMauroy. Please merge the Pull Request to incorporate the requested changes. Please tag @AugustinMauroy on your message if you have any questions related to the PR.

Security Fixes

Keeping your actions up to date with Dependabot

With Dependabot version updates, when Dependabot identifies an outdated dependency, it raises a pull request to update the manifest to the latest version of the dependency. This is recommended by GitHub as well as The Open Source Security Foundation (OpenSSF).

Feedback

For bug reports, feature requests, and general feedback; please email [email protected]. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot [email protected]

@step-security-bot step-security-bot requested a review from a team as a code owner November 23, 2024 09:35
Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 23, 2024 9:36am

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capture d’écran 2024-11-23 à 10 36 34

It's not solve this issue idk why we have this error

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont want daily updates do we??? earlier elements of our config indicate we do this monthly

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Nov 23, 2024

i'd probably move to close - I like this tool but I think we have this guidance handled already

@AugustinMauroy
Copy link
Member

i'd probably move to close - I like this tool but I think we have this guidance handled already

It's anoying you cannot have a preview of changes

@bmuenzenmeyer
Copy link
Collaborator

It's anoying you cannot have a preview of changes

we know what this is doing. it's completely ignoring all of our configuration and adding new config at the bottom, running EVERY dependency independently, without grouping, daily

  - package-ecosystem: npm
    directory: /apps/site
    schedule:
      interval: daily

  - package-ecosystem: npm
    directory: /packages/i18n
    schedule:
      interval: daily

this is not better than what we have today

@AugustinMauroy
Copy link
Member

i definitely allow with you

@varunsh-coder
Copy link

Hi @AugustinMauroy thanks for using StepSecurity to create this PR.

I wanted to mention why the tool added those sections. It is because the current dependabot config only applies to the root package.json file and will not update dependencies in the package.json files in the /apps/site and /packages/i18n directories. Please let me know if you think otherwise.

Also, you can preview changes when using the tool before creating a PR (screenshot below).
StepSecurityToolPreview

Please let me know if you have any questions/ comments. Happy to help and discuss any improvement ideas.

@AugustinMauroy
Copy link
Member

How wow I didn't know that that super cool ! Thanks

@bmuenzenmeyer
Copy link
Collaborator

What? This is the history of the apps/site package.json

Screenshot_20241123_185133_GitHub.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants