Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brew install corepack for current / pending releases #7120

Closed
wants to merge 2 commits into from

Conversation

karlhorky
Copy link

@karlhorky karlhorky commented Oct 12, 2024

Description

As reported in the issues below, Homebrew installation behavior is divergent with the latest releases and the older releases:

The short version is this:

  • brew install node@22: corepack not installed
  • brew install node@20 and older: corepack installed

Homebrew currently expects users to install Corepack separately with brew install corepack:

After this PR, brew install corepack is printed for releases with a .status of Current or Pending:

Node.js v22 (note the new line brew install corepack)

Screenshot 2024-10-12 at 18 19 14

Node.js v20

Screenshot 2024-10-12 at 18 18 56

Validation

Read into the issues above to validate the documented behavior of Homebrew.

Related Issues

Already linked above

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

cc @aduh95

@karlhorky karlhorky requested a review from a team as a code owner October 12, 2024 16:12
Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 12, 2024 4:18pm

Signed-off-by: Karl Horky <[email protected]>
@RedYetiDev
Copy link
Member

Users may not need/want to install corepack, so maybe just add a comment that explains that corepack is not distributed with the bundle?

@ovflowd
Copy link
Member

ovflowd commented Oct 12, 2024

I'm not a fan that Homebrew is intentionally changing how Node is installed (https://github.com/Homebrew/homebrew-core/blob/master/Formula/n/node.rb#L68-L88) by building Node natively and intentionally removing features.

At the same time, I cannot endorse manual extra steps to be added on our side on the downloads page. This must be resolved on Heombrew's side, and I'll report there and ask them to please not change the expected way people expect Node to perform across environments.

Unfortunately I don't think this change should land here, and I would discourage this as a fix.

@karlhorky
Copy link
Author

Sounds good, understood and agreed that Homebrew's divergent behavior seems unexpected and incorrect.

Closing.

@karlhorky karlhorky closed this Oct 12, 2024
@karlhorky karlhorky deleted the patch-1 branch October 12, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants