Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: create base eslint config #7057

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: create base eslint config #7057

wants to merge 2 commits into from

Conversation

araujogui
Copy link
Member

@araujogui araujogui commented Sep 23, 2024 •
edited
Loading

Description

Create base ESLint config

Validation

Well, ESLint works

Related Issues

Related to #5405

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Sep 24, 2024 3:48pm

araujogui
araujogui commented Sep 23, 2024
View reviewed changes
apps/site/eslint.config.js Outdated Show resolved Hide resolved
ovflowd
ovflowd reviewed Sep 23, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
ovflowd
ovflowd reviewed Sep 23, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
ovflowd
ovflowd approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the effort here! But the base config should have nothing TypeScript related, afaik!

@araujogui araujogui marked this pull request as ready for review September 24, 2024 15:48
@araujogui araujogui requested a review from a team as a code owner September 24, 2024 15:48
@araujogui araujogui added the github_actions:pull-request Trigger Pull Request Checks label Sep 25, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 75 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

@github-actions GitHub Actions
Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.47% (589/651) 76.29% (177/232) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.319s ⏱️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@araujogui @ovflowd @aymen94