-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6492 surfin 404 #7056
6492 surfin 404 #7056
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self-review, open to suggestions, especially on the tailwind conversion
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
at least on Chrome responsive mode this looks better. still testing
@ovflowd can you look again, this looks correct to me now on my phone. If you are concerned about the text, that is unrelated to the PR - this only alters the image |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really cool 😍 I have added a few minor comments about the Tailwind conversion
@bmuenzenmeyer thanks for helping get this over the finish line <3 |
Let's center it :D |
Co-authored-by: Caner Akdas <[email protected]> Signed-off-by: Brian Muenzenmeyer <[email protected]>
did not alter .special, as that is used for the homepage
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Cool new feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
I spent the weekend chipping away at @darcyclarke's rocket turtle animation. This will land the longest open PR we have, and it's an important bit of style 😎
prefers-reduced-motion
, per the TW docsValidation
Go to a non-existent page locally or on the preview.
Tested with
Chrome, Firefox, Edge
Mobile
Turn on
prefers reduced motion
, in your operating system of choice.After a bit, see the up and down animation cease to loop.
Related Issues
closes #6492
relates to #6480
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.