fix: Use default messages from en as fallback if messages are missing in another locale
#7054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng in another locale
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
reviewed
Sep 18, 2024
AugustinMauroy
approved these changes
Sep 19, 2024
aymen94
approved these changes
Sep 19, 2024
bmuenzenmeyer
approved these changes
Sep 21, 2024
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
joeeames
pushed a commit
to joeeames/nodejs.org
that referenced
this pull request
Sep 24, 2024
…ng in another locale (nodejs#7054) * fix: Use default messages from `en` as fallback if messages are missing in another locale * chore: Remove `deepmerge` dependency in favor of a more optimized custom function * chore: Revert changes to lockfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed on X with @ovflowd.
Note the missing messages were legit errors, I wouldn't disable the error handling.
Also, truly global error handling in
next-intlis currently unfortunately a bit cumbersome to set up, I'm waiting for better support on the Next.js side to improve this (see vercel/next.js#69294).Validation
Before:
After:
Related Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.[ ] I've covered new added functionality with unit tests if necessary.