refactor: remove unnecessary hook #6120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
|
Running Lighthouse audit... |
Unit Test Coverage Report
Unit Test Report
|
ovflowd
added
fast-track
github-actions
bot
removed
the
github_actions:pull-request
|
cc @nodejs/nodejs-website requesting this as a fast-track mostly because it's supposed to be a small refactor/fix to unblock other components |
canerakdas
reviewed
Nov 15, 2023
Co-authored-by: canerakdas <[email protected]> Signed-off-by: Claudio W <[email protected]>
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a Hook that is pretty much useless given we have the
ActiveLinkcomponent; This PR also updates the ActiveLink component to have same logic features as the previous Hook and updates the SideNavigation Component making it RSC-compatible and subsequently making the DocsLayout compatible.This PR also updates related styles as now the "active" class is on the link.
Validation
Deployment should work; Docs pages should work; Active Links should have active styling as before (Header and Side Navigation)
Related Issues
amannn/next-intl#611