Remove links to 3rd-party tools with Privacy issues. #2270
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,38 +77,10 @@ info on these follows: | |
| * The latest version can also be installed independently (e.g. `npm install -g node-inspect`) | ||
| and used with `node-inspect myscript.js`. | ||
|
|
||
|
There was a problem hiding this comment. This can be edited to recommend Chromium based and not Chrome though. |
||
|
There was a problem hiding this comment. I agree it is not our place to recommend these tools so +1 on removing them. There was a problem hiding this comment. As an alternative, VSCodium is VSCode without the trackers. There was a problem hiding this comment. Yes though why is it our place to recommend an IDE anyway? There was a problem hiding this comment. I don't know, but I thought the scope was about third-party privacy issues, not about not recommending tools. |
||
| #### [chrome-remote-interface](https://github.com/cyrus-and/chrome-remote-interface) | ||
|
|
||
| * Library to ease connections to Inspector Protocol endpoints. | ||
|
|
||
| --- | ||
|
|
||
| ## Command-line options | ||
|
|
@@ -205,8 +177,7 @@ $ ssh -L 9221:localhost:9229 [email protected] | |
|
|
||
| This starts a ssh tunnel session where a connection to port 9221 on your local | ||
| machine will be forwarded to port 9229 on remote.example.com. You can now attach | ||
|
There was a problem hiding this comment. I would keep DevTools and remove Visual Studio Code here |
||
| a debugger to localhost:9221, which should be able to debug as if the Node.js application was running locally. | ||
|
|
||
| --- | ||
|
|
||
|
|
@@ -230,12 +201,6 @@ command-line debugger. Your script starts in another Node process started with | |
| the `--debug-brk` option, and the initial Node process runs the `_debugger.js` | ||
| script and connects to your target. | ||
|
|
||
| <!-- refs --> | ||
|
|
||
| [Inspector Protocol]: https://chromedevtools.github.io/debugger-protocol-viewer/v8/ | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,38 +77,10 @@ info on these follows: | |
| * The latest version can also be installed independently (e.g. `npm install -g node-inspect`) | ||
| and used with `node-inspect myscript.js`. | ||
|
|
||
| #### [chrome-remote-interface](https://github.com/cyrus-and/chrome-remote-interface) | ||
|
|
||
| * Library to ease connections to Inspector Protocol endpoints. | ||
|
|
||
| --- | ||
|
|
||
| ## Command-line options | ||
|
|
@@ -205,7 +177,7 @@ $ ssh -L 9221:localhost:9229 [email protected] | |
|
|
||
| This starts a ssh tunnel session where a connection to port 9221 on your local | ||
| machine will be forwarded to port 9229 on remote.example.com. You can now attach | ||
| a debugger to localhost:9221, | ||
| which should be able to debug as if the Node.js application was running locally. | ||
|
|
||
| --- | ||
|
|
@@ -230,12 +202,6 @@ command-line debugger. Your script starts in another Node process started with | |
| the `--debug-brk` option, and the initial Node process runs the `_debugger.js` | ||
| script and connects to your target. | ||
|
|
||
| <!-- refs --> | ||
|
|
||
| [Inspector Protocol]: https://chromedevtools.github.io/debugger-protocol-viewer/v8/ | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -99,30 +99,6 @@ info on these follows: | |
| * The latest version can also be installed independently (e.g. `npm install -g node-inspect`) | ||
| and used with `node-inspect myscript.js`. | ||
|
|
||
| #### [chrome-remote-interface](https://github.com/cyrus-and/chrome-remote-interface) | ||
|
|
||
| * Library to ease connections to Inspector Protocol endpoints. | ||
|
|
@@ -223,7 +199,7 @@ $ ssh -L 9221:localhost:9229 [email protected] | |
|
|
||
| This starts a ssh tunnel session where a connection to port 9221 on your local | ||
| machine will be forwarded to port 9229 on remote.example.com. You can now attach | ||
| a debugger to localhost:9221, | ||
| which should be able to debug as if the Node.js application was running locally. | ||
|
|
||
| --- | ||
|
|
@@ -248,12 +224,6 @@ command-line debugger. Your script starts in another Node process started with | |
| the `--debug-brk` option, and the initial Node process runs the `_debugger.js` | ||
| script and connects to your target. | ||
|
|
||
| <!-- refs --> | ||
|
|
||
| [Inspector Protocol]: https://chromedevtools.github.io/debugger-protocol-viewer/v8/ | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -166,78 +166,10 @@ info on these follows: | |
| * バージョンは Node にバンドルされており、`node inspect myscript.js`と一緒に使うことができます | ||
| * 最新バージョンは独立してインストールすることもでき (例えば `npm install -g node-inspect`)、 `node-inspect myscript.js` と一緒に使うことができます | ||
|
|
||
| #### [chrome-remote-interface](https://github.com/cyrus-and/chrome-remote-interface) | ||
|
|
||
| * Inspector Protocol エンドポイントへの接続を容易にするためのライブラリ | ||
|
|
||
| --- | ||
|
|
||
| <!-- | ||
|
|
@@ -404,7 +336,7 @@ $ ssh -L 9221:localhost:9229 [email protected] | |
|
|
||
| This starts a ssh tunnel session where a connection to port 9221 on your local | ||
| machine will be forwarded to port 9229 on remote.example.com. You can now attach | ||
| a debugger to localhost:9221, | ||
| which should be able to debug as if the Node.js application was running locally. | ||
|
|
||
| --- | ||
|
|
@@ -485,20 +417,6 @@ Node の組み込みコマンドラインデバッガの下でスクリプトを | |
| スクリプトは `--debug-brk` オプションで開始された別のノードプロセスで開始され、 | ||
| 最初のノードプロセスは `_debugger.js` スクリプトを実行してターゲットに接続します。 | ||
|
|
||
| <!-- refs --> | ||
|
|
||
| <!-- | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,66 +144,10 @@ Node 인스펙터에 접속할 수 있는 여러 상용 도구와 오픈소스 | |
| * 최신 버전을 별도로 설치할 수 있고(예시: `npm install -g node-inspect`) | ||
| `node-inspect myscript.js`로 사용할 수 있습니다. | ||
|
|
||
| #### [chrome-remote-interface](https://github.com/cyrus-and/chrome-remote-interface) | ||
|
|
||
| * 인스펙터 프로토콜 엔드포인트로의 연결을 쉽게 하는 라이브러리입니다. | ||
|
|
||
| --- | ||
|
|
||
| <!-- | ||
|
|
@@ -380,10 +324,10 @@ $ ssh -L 9221:localhost:9229 [email protected] | |
| <!-- | ||
| This starts a ssh tunnel session where a connection to port 9221 on your local | ||
| machine will be forwarded to port 9229 on remote.example.com. You can now attach | ||
| a debugger to localhost:9221, | ||
| which should be able to debug as if the Node.js application was running locally. | ||
| --> | ||
| 그러면 로컬 시스템의 9221 포트에서 remote.example.com의 9229 포트로 전달되는 ssh 터널 세션이 시작됩니다. 등의 디버거로 localhost:9221에 연결 할 수 있으며 Node.js 애플리케이션이 로컬에서 실행 중인 것처럼 디버깅할 수 있습니다. | ||
|
|
||
| --- | ||
|
|
||
|
|
@@ -420,12 +364,6 @@ Start `node debug script_name.js` to start your script under Node's builtin | |
| command-line debugger. Your script starts in another Node process started with | ||
| the `--debug-brk` option, and the initial Node process runs the `_debugger.js` | ||
| script and connects to your target. | ||
| --> | ||
|
|
||
| #### [내장 디버거](https://nodejs.org/dist/latest-v6.x/docs/api/debugger.html) | ||
|
|
@@ -434,11 +372,6 @@ Node의 내장 명령형 디버거로 스크립트를 실행하려면 `node debu | |
| 스크립트가 다른 Node 프로세스에서 `--debug-brk` 옵션으로 시작되고 원래의 Node 프로세스는 | ||
| `_debugger.js`를 실행해서 대상에 접속합니다. | ||
|
|
||
| <!-- refs --> | ||
|
|
||
| <!-- | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a link to a mirror from the Chromium repo which is what's being tested against the Node inspector. If we remove this we need another alternative "blessed" frontend and to run tests against it.
I think we should keep this in the docs for now since the two interconnected parts (v8 and the devtools frontend) are part of the same open source project (chromium) and v8 is a hard dependency of Node.
As an alternative - we might want to ship this.