Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/translation ru #2243

Merged
merged 31 commits into from
Jun 22, 2019
Merged

Conversation

alexandrtovmach
Copy link
Contributor

Here is the full Russian translation of the website except guides and privacy policy

A few moments:

  • Official Russian repository nodejs/nodejs-ru community is archived, and in that case I send direct PR
  • If it's possible I'd happy to be a contributor and/or owner of the nodejs/nodejs-ru repository, to continue active localization process of Node.js

@Trott
Copy link
Member

Trott commented May 27, 2019

Here is the full Russian translation of the website except guides and privacy policy

A few moments:

  • Official Russian repository nodejs/nodejs-ru community is archived, and in that case I send direct PR
  • If it's possible I'd happy to be a contributor and/or owner of the nodejs/nodejs-ru repository, to continue active localization process of Node.js

/ping @nodejs/community-committee What's the best way for @alexandrtovmach to proceed with continued active maintenance of the Russian translation? CrowdIn? Something else? I don't want to ping @nodejs/localization because that's 165 people or something. Is there a sort of @nodejs/localization-admin team or something like that?

@keywordnew
Copy link
Contributor

@obensource is this something yet within the purview of nodejs/i18n?

@WaleedAshraf
Copy link
Contributor

maybe it's good to ping some of the contributors of nodejs/nodejs-ru here?
cc @Olegas @gko

@alexandrtovmach
Copy link
Contributor Author

@WaleedAshraf I'm not sure that's useful, because they stopped active contributing 4 years ago

@alexandrtovmach
Copy link
Contributor Author

@keywordnew nodejs/i18n group working on API docs translation, in this PR I've translated the website

@Trott
Copy link
Member

Trott commented Jun 1, 2019

Maybe @ChALkeR (or some other regular contributor who speaks Russian) has time to look it over a little bit and can give it a rubber-stamp approval? In other words, something like "I gave this a cursory review, skimming a few pages, and it looks good to me, but I did not review it thoroughly."

(We have two issues here: First, getting this reviewed and up on the website. Second, what is the preferred way we do these things going forward? Do we just keep the translation here and do it through PRs like this? Or is there another mechanism? I seem to recall CrowdIn being used, but I know nothing about if that's continued or not. /ping @zeke)

@ghost
Copy link

ghost commented Jun 3, 2019

@nodejs/nodejs-ru:Anyone has a review of that?

@alexandrtovmach
Copy link
Contributor Author

Any updates with that? How can I help to proceed now?

@Trott
Copy link
Member

Trott commented Jun 7, 2019

Hmmm...I'm not sure who speaks Russian in Node.js core besides Chalker, but going on educated guesswork here, maybe @indutny or @vsemozhetbyt might be able to give this at least a cursory review?

Copy link
Contributor

@ghaiklor ghaiklor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall everything is ok, but sometimes there are obvious points in text, where reader can see an artifact of computer translation.

I'd say, nothing critical or blocking here, but I did not review the whole PR word by word, it is huge. For the next time, it will be much better to make smaller PRs.

locale/ru/about/community.md Outdated Show resolved Hide resolved
locale/ru/about/index.md Outdated Show resolved Hide resolved
locale/ru/about/trademark.md Outdated Show resolved Hide resolved
locale/ru/docs/es6.md Outdated Show resolved Hide resolved
@alexandrtovmach
Copy link
Contributor Author

@ghaiklor Thanks for a quick review. I'll add this fixes in next few days.

@alexandrtovmach
Copy link
Contributor Author

So finally I've added requested changes. Seems like we can merge

@Trott Trott merged commit 8a86c37 into nodejs:master Jun 22, 2019
@alexandrtovmach
Copy link
Contributor Author

@Trott Thanks for merging. We still have open question about continuing translation process. Do I need to close this PR and open separate issue?

@Trott
Copy link
Member

Trott commented Jun 22, 2019

Do I need to close this PR and open separate issue?

Yes, that will work!

@badJaguar
Copy link

Let's try to translate Documentation.

@alexandrtovmach
Copy link
Contributor Author

@badJaguar To work on documentation translation please use https://crowdin.com/project/nodejs/ru

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants