-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch/translation ru #2243
Patch/translation ru #2243
Conversation
/ping @nodejs/community-committee What's the best way for @alexandrtovmach to proceed with continued active maintenance of the Russian translation? CrowdIn? Something else? I don't want to ping |
@obensource is this something yet within the purview of nodejs/i18n? |
@WaleedAshraf I'm not sure that's useful, because they stopped active contributing 4 years ago |
@keywordnew nodejs/i18n group working on API docs translation, in this PR I've translated the website |
Maybe @ChALkeR (or some other regular contributor who speaks Russian) has time to look it over a little bit and can give it a rubber-stamp approval? In other words, something like "I gave this a cursory review, skimming a few pages, and it looks good to me, but I did not review it thoroughly." (We have two issues here: First, getting this reviewed and up on the website. Second, what is the preferred way we do these things going forward? Do we just keep the translation here and do it through PRs like this? Or is there another mechanism? I seem to recall CrowdIn being used, but I know nothing about if that's continued or not. /ping @zeke) |
@nodejs/nodejs-ru:Anyone has a review of that? |
Any updates with that? How can I help to proceed now? |
Hmmm...I'm not sure who speaks Russian in Node.js core besides Chalker, but going on educated guesswork here, maybe @indutny or @vsemozhetbyt might be able to give this at least a cursory review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall everything is ok, but sometimes there are obvious points in text, where reader can see an artifact of computer translation.
I'd say, nothing critical or blocking here, but I did not review the whole PR word by word, it is huge. For the next time, it will be much better to make smaller PRs.
@ghaiklor Thanks for a quick review. I'll add this fixes in next few days. |
So finally I've added requested changes. Seems like we can merge |
@Trott Thanks for merging. We still have open question about continuing translation process. Do I need to close this PR and open separate issue? |
Yes, that will work! |
Let's try to translate Documentation. |
@badJaguar To work on documentation translation please use https://crowdin.com/project/nodejs/ru |
Here is the full Russian translation of the website except guides and privacy policy
A few moments: