cli: allow test coverage, module mocks, and snapshots in NODE_OPTIONS

[JakobJingleheimer]

After asking the @nodejs/test_runner team, there does not appear to be a particular reason these are not already included.

[JakobJingleheimer]

No I didn't…

[ljharb]

@JakobJingleheimer ffr the api request to change github labels is done as a "here's all the labels this issue has" request, not a delta, so there was a race condition between you and the bot. the bot said "it's just these 2!" and you said "it's just this 1!".

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (d5d1e80) to head (df9e99c).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #56114   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files         656      656           
  Lines      189002   189002           
  Branches    36003    36000    -3     
=======================================
+ Hits       166335   166338    +3     
- Misses      15838    15839    +1     
+ Partials     6829     6825    -4     

Files with missing lines	Coverage Δ
src/node_options.cc	87.55% <100.00%> (ø)

... and 28 files with indirect coverage changes

[GeoffreyBooth]

Are these the only flags that need adding to NODE_OPTIONS? Or at least the only test runner-related ones. We might as well add all the missing ones, or at least the missing test runner flags, while we’re at it.

[JakobJingleheimer]

I have no idea why only some flags are allowed in NODE_OPTIONS, and I can't find anyone who knows.

[cjihrig]

I haven't tested, but I would expect passing --experimental-test-coverage in NODE_OPTIONS to cause problems.

[JakobJingleheimer]

Why?

[cjihrig]

The test runner explicitly tries to filter that argument out when launching worker processes, but NODE_OPTIONS sidesteps that. It may work, but I wouldn't count on it.

[JakobJingleheimer]

Thanks! I'll test that locally against nodejs/userland-migrations#7, which should spawn workers via test runner.