Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: resolve the issue of not adhering to the specified buffersize #55896

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cu8code
Copy link

@cu8code cu8code commented Nov 17, 2024

ref: #55764

We create a queueHandler, and in every iteration we execute the handlers in the queueHandler until we get a non-null result.

We create a `queueHandler`, and in every iteration we execute
the handlers in the `queueHandler` until we get a non-null result.
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 17, 2024
@cu8code
Copy link
Author

cu8code commented Nov 17, 2024

@Ethan-Arrowood, please take a look at the PR when you have a chance. It should be ready for merge unless some any issues is found!

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Project coverage is 87.91%. Comparing base (e577618) to head (62a5334).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/fs/dir.js 80.48% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55896      +/-   ##
==========================================
- Coverage   87.91%   87.91%   -0.01%     
==========================================
  Files         654      654              
  Lines      187853   187880      +27     
  Branches    35823    35845      +22     
==========================================
+ Hits       165158   165177      +19     
+ Misses      15904    15887      -17     
- Partials     6791     6816      +25     
Files with missing lines Coverage Δ
lib/internal/fs/dir.js 95.05% <80.48%> (-2.17%) ⬇️

... and 31 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants