Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite: refactor open options #55442

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tniessen
Copy link
Member

Move options that are only relevant for opening the database into a self-contained class.

Refs: #54777 (comment)

Move options that are only relevant for opening the database into a
self-contained class.
@tniessen tniessen added the sqlite Issues and PRs related to the SQLite subsystem. label Oct 18, 2024
@tniessen tniessen requested a review from jasnell October 18, 2024 09:54
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (ddfef05) to head (dc87f5c).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55442      +/-   ##
==========================================
- Coverage   88.42%   88.40%   -0.02%     
==========================================
  Files         652      653       +1     
  Lines      186918   187605     +687     
  Branches    36079    36120      +41     
==========================================
+ Hits       165279   165851     +572     
- Misses      14892    14979      +87     
- Partials     6747     6775      +28     
Files with missing lines Coverage Δ
src/node_sqlite.h 73.33% <100.00%> (+73.33%) ⬆️
src/node_sqlite.cc 83.36% <87.50%> (-0.37%) ⬇️

... and 104 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants