Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: stop using deprecated ares_query #55430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RedYetiDev
Copy link
Member

Ref: #52464

ares_query has been deprecated in favor of ares_query_dnsrec, so this PR switches our implementation to use it.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels Oct 17, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (fa8f149) to head (de2f7ff).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/cares_wrap.cc 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55430      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.02%     
==========================================
  Files         652      653       +1     
  Lines      186918   187603     +685     
  Branches    36072    36118      +46     
==========================================
+ Hits       165270   165856     +586     
- Misses      14891    14970      +79     
- Partials     6757     6777      +20     
Files with missing lines Coverage Δ
src/cares_wrap.h 79.89% <100.00%> (+2.18%) ⬆️
src/cares_wrap.cc 65.16% <41.66%> (ø)

... and 106 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants