V22.10.0 proposal

.clang-format

@@ -9,11 +9,11 @@ AlignEscapedNewlines: Right
 AlignOperands: true
 AlignTrailingComments: true
 AllowAllParametersOfDeclarationOnNextLine: true
-AllowShortBlocksOnASingleLine: Never
+AllowShortBlocksOnASingleLine: false
 AllowShortCaseLabelsOnASingleLine: false
 AllowShortFunctionsOnASingleLine: Inline
 AllowShortIfStatementsOnASingleLine: true
-AllowShortLoopsOnASingleLine: false
+AllowShortLoopsOnASingleLine: true
 AlwaysBreakAfterDefinitionReturnType: None
 AlwaysBreakAfterReturnType: None
 AlwaysBreakBeforeMultilineStrings: false

.configurations/configuration.dsc.yaml

@@ -0,0 +1,54 @@
+# yaml-language-server: $schema=https://aka.ms/configuration-dsc-schema/0.2
+# Reference: https://github.com/nodejs/node/blob/main/BUILDING.md#windows
+properties:
+ resources:
+ - resource: Microsoft.WinGet.DSC/WinGetPackage
+ id: pythonPackage
+ directives:
+ description: Install Python 3.12
+ module: Microsoft.WinGet.DSC
+ allowPrerelease: true
+ settings:
+ id: Python.Python.3.12
+ source: winget
+ - resource: Microsoft.WinGet.DSC/WinGetPackage
+ id: vsPackage
+ directives:
+ description: Install Visual Studio 2022 Community
+ allowPrerelease: true
+ settings:
+ id: Microsoft.VisualStudio.2022.Community
+ source: winget
+ useLatest: true
+ - resource: Microsoft.VisualStudio.DSC/VSComponents
+ id: vsComponents
+ dependsOn:
+ - vsPackage
+ directives:
+ description: Install required VS workloads and components
+ allowPrerelease: true
+ settings:
+ productId: Microsoft.VisualStudio.Product.Community
+ channelId: VisualStudio.17.Release
+ includeRecommended: true
+ components:
+ - Microsoft.VisualStudio.Workload.NativeDesktop
+ - Microsoft.VisualStudio.Component.VC.Llvm.Clang
+ - Microsoft.VisualStudio.Component.VC.Llvm.ClangToolset
+ - resource: Microsoft.WinGet.DSC/WinGetPackage
+ id: gitPackage
+ directives:
+ description: Install Git
+ allowPrerelease: true
+ settings:
+ id: Git.Git
+ source: winget
+ - resource: Microsoft.WinGet.DSC/WinGetPackage
+ id: nasmPackage
+ directives:
+ description: Install NetWide Assembler (NASM)
+ allowPrerelease: true
+ settings:
+ id: Nasm.Nasm
+ source: winget
+ configurationVersion: 0.1.0

.configurations/configuration.vsEnterprise.dsc.yaml

@@ -0,0 +1,54 @@
+# yaml-language-server: $schema=https://aka.ms/configuration-dsc-schema/0.2
+# Reference: https://github.com/nodejs/node/blob/main/BUILDING.md#windows
+properties:
+ resources:
+ - resource: Microsoft.WinGet.DSC/WinGetPackage
+ id: pythonPackage
+ directives:
+ description: Install Python 3.12
+ module: Microsoft.WinGet.DSC
+ allowPrerelease: true
+ settings:
+ id: Python.Python.3.12
+ source: winget
+ - resource: Microsoft.WinGet.DSC/WinGetPackage
+ id: vsPackage
+ directives:
+ description: Install Visual Studio 2022 Enterprise
+ allowPrerelease: true
+ settings:
+ id: Microsoft.VisualStudio.2022.Enterprise
+ source: winget
+ useLatest: true
+ - resource: Microsoft.VisualStudio.DSC/VSComponents
+ id: vsComponents
+ dependsOn:
+ - vsPackage
+ directives:
+ description: Install required VS workloads and components
+ allowPrerelease: true
+ settings:
+ productId: Microsoft.VisualStudio.Product.Enterprise
+ channelId: VisualStudio.17.Release
+ includeRecommended: true
+ components:
+ - Microsoft.VisualStudio.Workload.NativeDesktop
+ - Microsoft.VisualStudio.Component.VC.Llvm.Clang
+ - Microsoft.VisualStudio.Component.VC.Llvm.ClangToolset
+ - resource: Microsoft.WinGet.DSC/WinGetPackage
+ id: gitPackage
+ directives:
+ description: Install Git
+ allowPrerelease: true
+ settings:
+ id: Git.Git
+ source: winget
+ - resource: Microsoft.WinGet.DSC/WinGetPackage
+ id: nasmPackage
+ directives:
+ description: Install NetWide Assembler (NASM)
+ allowPrerelease: true
+ settings:
+ id: Nasm.Nasm
+ source: winget
+ configurationVersion: 0.1.0

.configurations/configuration.vsProfessional.dsc.yaml

@@ -0,0 +1,54 @@
+# yaml-language-server: $schema=https://aka.ms/configuration-dsc-schema/0.2
+# Reference: https://github.com/nodejs/node/blob/main/BUILDING.md#windows
+properties:
+ resources:
+ - resource: Microsoft.WinGet.DSC/WinGetPackage
+ id: pythonPackage
+ directives:
+ description: Install Python 3.12
+ module: Microsoft.WinGet.DSC
+ allowPrerelease: true
+ settings:
+ id: Python.Python.3.12
+ source: winget
+ - resource: Microsoft.WinGet.DSC/WinGetPackage
+ id: vsPackage
+ directives:
+ description: Install Visual Studio 2022 Professional
+ allowPrerelease: true
+ settings:
+ id: Microsoft.VisualStudio.2022.Professional
+ source: winget
+ useLatest: true
+ - resource: Microsoft.VisualStudio.DSC/VSComponents
+ id: vsComponents
+ dependsOn:
+ - vsPackage
+ directives:
+ description: Install required VS workloads and components
+ allowPrerelease: true
+ settings:
+ productId: Microsoft.VisualStudio.Product.Professional
+ channelId: VisualStudio.17.Release
+ includeRecommended: true
+ components:
+ - Microsoft.VisualStudio.Workload.NativeDesktop
+ - Microsoft.VisualStudio.Component.VC.Llvm.Clang
+ - Microsoft.VisualStudio.Component.VC.Llvm.ClangToolset
+ - resource: Microsoft.WinGet.DSC/WinGetPackage
+ id: gitPackage
+ directives:
+ description: Install Git
+ allowPrerelease: true
+ settings:
+ id: Git.Git
+ source: winget
+ - resource: Microsoft.WinGet.DSC/WinGetPackage
+ id: nasmPackage
+ directives:
+ description: Install NetWide Assembler (NASM)
+ allowPrerelease: true
+ settings:
+ id: Nasm.Nasm
+ source: winget
+ configurationVersion: 0.1.0

.cpplint

@@ -1,3 +1,3 @@
 set noparent
-filter=-build/include_alpha,-build/include_subdir,-build/include_what_you_use,-legal/copyright,-readability/nolint
+filter=-build/include_alpha,-build/include_subdir,-build/include_what_you_use,-legal/copyright,-readability/nolint,-readability/braces
 linelength=80

.github/ISSUE_TEMPLATE/config.yml

@@ -1,8 +1,14 @@
 blank_issues_enabled: true
 contact_links:
- - name: ⁉️ Need help with Node.js?
+ - name: ⁉️ Need general help with Node.js?
  url: https://github.com/nodejs/help
  about: Please file an issue in our help repo.
+ - name: 📦 Have an issue with npm?
+ url: https://github.com/npm/cli/issues
+ about: npm has a seperate issue tracker.
+ - name: 📡 Have an issue with undici? (`WebSocket`, `fetch`, etc.)
+ url: https://github.com/nodejs/undici/issues
+ about: Undici has a seperate issue tracker.
  - name: 🌐 Found a problem with nodejs.org beyond the API reference docs?
  url: https://github.com/nodejs/nodejs.org/issues/new/choose
  about: Please file an issue in the Node.js website repo.

.github/workflows/auto-start-ci.yml

@@ -45,12 +45,12 @@ jobs:
  if: needs.get-prs-for-ci.outputs.numbers != ''
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+ - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
  with:
  persist-credentials: false
 
  - name: Install Node.js
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
+ uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
  with:
  node-version: ${{ env.NODE_VERSION }}
 

.github/workflows/build-tarball.yml

@@ -42,15 +42,15 @@ jobs:
  if: github.event.pull_request.draft == false
  runs-on: ubuntu-24.04
  steps:
- - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+ - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
  uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Set up sccache
- uses: mozilla-actions/sccache-action@89e9040de88b577a072e3760aaf59f585da083af # v0.0.5
+ uses: mozilla-actions/sccache-action@9e326ebed976843c9932b3aa0e021c6f50310eb4 # v0.0.6
  with:
  version: v0.8.1
  - name: Environment Information
@@ -72,15 +72,15 @@ jobs:
  needs: build-tarball
  runs-on: ubuntu-24.04
  steps:
- - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+ - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
  uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Set up sccache
- uses: mozilla-actions/sccache-action@89e9040de88b577a072e3760aaf59f585da083af # v0.0.5
+ uses: mozilla-actions/sccache-action@9e326ebed976843c9932b3aa0e021c6f50310eb4 # v0.0.6
  with:
  version: v0.8.1
  - name: Environment Information

.github/workflows/commit-lint.yml

@@ -17,13 +17,13 @@ jobs:
  run: |
  echo "plusOne=$((${{ github.event.pull_request.commits }} + 1))" >> $GITHUB_OUTPUT
  echo "minusOne=$((${{ github.event.pull_request.commits }} - 1))" >> $GITHUB_OUTPUT
- - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+ - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
  with:
  fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}
  persist-credentials: false
  - run: git reset HEAD^2
  - name: Install Node.js
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
+ uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
  with:
  node-version: ${{ env.NODE_VERSION }}
  - name: Validate commit message

.github/workflows/commit-queue.yml

@@ -58,7 +58,7 @@ jobs:
  if: needs.get_mergeable_prs.outputs.numbers != ''
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+ - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
  with:
  # Needs the whole git history for ncu to work
  # See https://github.com/nodejs/node-core-utils/pull/486
@@ -71,7 +71,7 @@ jobs:
 
  # Install dependencies
  - name: Install Node.js
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
+ uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
  with:
  node-version: ${{ env.NODE_VERSION }}
  - name: Install @node-core/utils

.github/workflows/coverage-linux-without-intl.yml

@@ -13,6 +13,7 @@ on:
  - tools/test.py
  - .github/workflows/coverage-linux-without-intl.yml
  - codecov.yml
+ - .nycrc
  push:
  branches:
  - main
@@ -26,6 +27,7 @@ on:
  - tools/test.py
  - .github/workflows/coverage-linux-without-intl.yml
  - codecov.yml
+ - .nycrc
 
 concurrency:
  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
@@ -46,15 +48,15 @@ jobs:
  if: github.event.pull_request.draft == false
  runs-on: ubuntu-24.04
  steps:
- - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+ - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
  uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Set up sccache
- uses: mozilla-actions/sccache-action@89e9040de88b577a072e3760aaf59f585da083af # v0.0.5
+ uses: mozilla-actions/sccache-action@9e326ebed976843c9932b3aa0e021c6f50310eb4 # v0.0.6
  with:
  version: v0.8.1
  - name: Environment Information