Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add --heap-prof flag available to NODE_OPTIONS #54259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cli: add --heap-prof flag available to NODE_OPTIONS #54259

wants to merge 1 commit into from
+24 −4

Conversation

juanarbol
Copy link
Member

@juanarbol juanarbol commented Aug 7, 2024 •
edited
Loading

Fixes: #54257

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 7, 2024
@himself65
Copy link
Member

title should be prof not proof

@juanarbol juanarbol changed the title cli: add --heap-proof flag available to NODE_OPTIONS cli: add --heap-prof flag available to NODE_OPTIONS Aug 7, 2024
@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60956/

@RedYetiDev RedYetiDev added the cli Issues and PRs related to the Node.js command line interface. label Aug 8, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (10addb0) to head (86cd89b).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54259   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files         652      652           
  Lines      186864   186878   +14     
  Branches    36064    36065    +1     
=======================================
+ Hits       165217   165234   +17     
- Misses      14888    14891    +3     
+ Partials     6759     6753    -6
Files with missing lines Coverage Δ
src/node_options.cc 87.40% <ø> (ø)

... and 34 files with indirect coverage changes

@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60961/

@juanarbol
Copy link
Member Author

Not sure why https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu2204_sharedlibs_withoutssl_x64/45126/ failed and the rest of the platform passed the tests affected by this patch. Will retry rn (it may be a cache at compile time issue)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60968/

@juanarbol
Copy link
Member Author

The failure is persistent, not sure what is wrong with this. Any clues?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60984/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60992/

@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 13, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 13, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61072/

@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61122/

@targos
Copy link
Member

targos commented Aug 24, 2024

The changes you did are under #if HAVE_INSPECTOR, so I guess these jobs don't enable the inspector.

@richardlau
Copy link
Member

The changes you did are under #if HAVE_INSPECTOR, so I guess these jobs don't enable the inspector.

Specifically, the inspector isn't available without SSL support.

@RedYetiDev RedYetiDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. stalled Issues and PRs that are stalled. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@RedYetiDev
Copy link
Member

@juanarbol There hasn't been any activity on this PR in a while, and there are comments that need to be addressed before it can land, so I've marked it as stalled

@juanarbol
Copy link
Member Author

I'll fix this one, sorry on the dealy

@juanarbol juanarbol removed the stalled Issues and PRs that are stalled. label Oct 14, 2024
@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63099/

@juanarbol juanarbol added request-ci Add this label to start a Jenkins CI on a PR. and removed c++ Issues and PRs that require attention from people who are familiar with C++. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 14, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63105/

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 15, 2024
@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63106/

@juanarbol juanarbol added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 15, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 15, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/54259
✔  Done loading data for nodejs/node/pull/54259
----------------------------------- PR info ------------------------------------
Title      cli: add `--heap-prof` flag available to `NODE_OPTIONS` (#54259)
Author     Juan José <[email protected]> (@juanarbol)
Branch     juanarbol:juan/heap-proof -> nodejs:main
Labels     cli, author ready, needs-ci
Commits    1
 - cli: add `--heap-prof` flag available to `NODE_OPTIONS`
Committers 1
 - Juan José Arboleda <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54259
Fixes: https://github.com/nodejs/node/issues/54257
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54259
Fixes: https://github.com/nodejs/node/issues/54257
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - cli: add `--heap-prof` flag available to `NODE_OPTIONS`
   ℹ  This PR was created on Wed, 07 Aug 2024 23:37:44 GMT
   ✔  Approvals: 3
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/54259#pullrequestreview-2226360285
   ✔  - Franziska Hinkelmann (@fhinkel): https://github.com/nodejs/node/pull/54259#pullrequestreview-2228987134
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54259#pullrequestreview-2231718770
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-10-15T00:34:10Z: https://ci.nodejs.org/job/node-test-pull-request/63106/
- Querying data for job/node-test-pull-request/63106/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/11340145799

@juanarbol
Copy link
Member Author

It’s being a while w/out landing something. Can anyone review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@anonrig anonrig anonrig approved these changes

@himself65 himself65 himself65 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cli Issues and PRs related to the Node.js command line interface. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--heap-prof is not allowed in NODE_OPTIONS
8 participants
@juanarbol @himself65 @nodejs-github-bot @targos @richardlau @RedYetiDev @fhinkel @anonrig