v12.9.1 release proposal #29321
Merged
v12.9.1 release proposal #29321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 779a05d. PR-URL: #29263 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This test covers a regression where 'end' was not emitted in the case of keepalive requests without parsing the full body. PR-URL: #29263 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
I don't think so, Tim. PR-URL: #29234 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
i2d_SSL_SESSION() can return a value <= 0 when the session is malformed or otherwise invalid. Handle that case. This change comes without a regression test because I couldn't figure out a good way to generate an existing but invalid session in a timely fashion. Fixes: #29202 PR-URL: #29225 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #29239 PR-URL: #29245 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
This commit removes unused using declarations in src/node_contextify.cc. PR-URL: #29222 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs-github-bot
added
c++
|
/cc @nodejs/collaborators @nodejs/releasers @nodejs/tsc |
|
@mcollina sure, but it has to land on master first. |
gengjiawen
approved these changes
Aug 26, 2019
cjihrig
approved these changes
Aug 26, 2019
evanlucas
approved these changes
Aug 26, 2019
This resolves a memory leak for keep-alive connections and does not regress in the way that 779a05d did by waiting for the incoming request to be finished before releasing the `parser.incoming` object. Refs: #28646 Refs: #29263 Fixes: #9668 PR-URL: #29297 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Notable changes: This release fixes two regressions in the http module: * Fixes an event listener leak in the HTTP client. This resulted in lots of warnings during npm/yarn installs. #29245 * Fixes a regression preventing the `'end'` event from being emitted for keepalive requests in case the full body was not parsed. #29263 PR-URL: #29321
targos
force-pushed
the
v12.9.1-proposal
branch
from
0c2b98f
to
9cfb384
Compare
Trott
approved these changes
Aug 26, 2019
targos
added a commit
that referenced
this pull request
Aug 26, 2019
Notable changes: This release fixes two regressions in the http module: * Fixes an event listener leak in the HTTP client. This resulted in lots of warnings during npm/yarn installs. #29245 * Fixes a regression preventing the `'end'` event from being emitted for keepalive requests in case the full body was not parsed. #29263 PR-URL: #29321
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Aug 26, 2019
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Aug 26, 2019
targos
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2019-08-26, Version 12.9.1 (Current), @targos
Notable changes
This release fixes two regressions in the http module:
warnings during npm/yarn installs (Robert Nagy) #29245.
'end'event from being emitted forkeepalive requests in case the full body was not parsed (Matteo Collina) #29263.
Commits
3cc8fca299] - crypto: handle i2d_SSL_SESSION() error return (Ben Noordhuis) #29225dedbd119c5] - http: fix event listener leak (Robert Nagy) #29245f8f8754d43] - Revert "http: reset parser.incoming when server response is finished" (Matteo Collina) #29263a6abfcb423] - src: remove unused using declarations (Daniel Bevenius) #29222ff6330a6ac] - test: fix 'timeout' typos (cjihrig) #292343c7a1a9090] - test, http: add regression test for keepalive 'end' event (Matteo Collina) #29263