dns: honor the order option

Fixes: #55391
nodejs · Oct 15, 2024 · 6b90982 · 6b90982
1 parent 51d8146
commit 6b90982
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/dns.js b/lib/dns.js
@@ -193,7 +193,7 @@ function lookup(hostname, options, callback) {
  }
  if (options?.order != null) {
  validateOneOf(options.order, 'options.order', ['ipv4first', 'ipv6first', 'verbatim']);
- dnsOrder = options.dnsOrder;
+ dnsOrder = options.order;
  }
  }
 

diff --git a/test/parallel/test-dns-default-order-verbatim.js b/test/parallel/test-dns-default-order-verbatim.js
@@ -46,4 +46,14 @@ function allowFailed(fn) {
 
  await allowFailed(dnsPromises.lookup('example.org', {}));
  checkParameter(cares.DNS_ORDER_VERBATIM);
+
+ await allowFailed(
+ promisify(dns.lookup)('example.org', { order: 'ipv4first' })
+ );
+ checkParameter(cares.DNS_ORDER_IPV4_FIRST);
+
+ await allowFailed(
+ promisify(dns.lookup)('example.org', { order: 'ipv6first' })
+ );
+ checkParameter(cares.DNS_ORDER_IPV6_FIRST);
 })().then(common.mustCall());