fix: Ensure Duplex streams
are returned unwrapped in stream operators
#57334
Annotations
10 errors and 1 notice
Test:
test/parallel/test-stream-drop-take.js#L66
--- stderr ---
node:stream:80
throw new ERR_INVALID_ARG_VALUE('result', result, 'must be a Duplex, Readable, or Writable stream');
^
TypeError [ERR_INVALID_ARG_VALUE]: The argument 'result' must be a Duplex, Readable, or Writable stream. Received Object [AsyncGenerator] {}
at Readable.take (node:stream:80:11)
at Object.<anonymous> (/Users/runner/work/node/node/test/parallel/test-stream-drop-take.js:66:10)
at Module._compile (node:internal/modules/cjs/loader:1568:14)
at Object..js (node:internal/modules/cjs/loader:1711:10)
at Module.load (node:internal/modules/cjs/loader:1328:32)
at Function._load (node:internal/modules/cjs/loader:1138:12)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5)
at node:internal/main/run_main_module:36:49 {
code: 'ERR_INVALID_ARG_VALUE'
}
Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-stream-drop-take.js
|
Test:
test/parallel/test-stream-duplex.js#L159
--- stderr ---
node:assert:90
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: Expected the Duplex stream to be returned unchanged
+ actual - expected ... Lines skipped
Duplex {
[Symbol(kCapture)]: false,
[Symbol(shapeMode)]: true,
+ _destroy: [Function (anonymous)],
+ _events: {
+ close: undefined,
+ data: undefined,
+ drain: undefined,
+ end: undefined,
+ error: undefined,
+ finish: undefined,
+ prefinish: undefined,
+ readable: undefined
+ },
+ _maxListeners: undefined,
+ _read: [Function (anonymous)],
+ _readableState: ReadableState {
+ [Symbol(kState)]: 1052940,
+ awaitDrainWriters: null,
+ buffer: [],
+ bufferIndex: 0,
+ highWaterMark: 65536,
+ length: 0,
+ pipes: []
+ },
+ _writableState: WritableState {
+ [Symbol(kBufferedValue)]: null,
...
- _events: {
- close: [
- [Function (anonymous)],
- [Function: onclose],
- [Function (anonymous)],
- [Function: bound onceWrapper] {
- listener: [Function: onclose]
- },
- [Function: onclose]
- ],
- data: undefined,
- drain: undefined,
- end: [
- [Function: onend],
- [Function: onend],
- [Function (anonymous)]
- ],
- error: [
- [Function: onerror],
- [Function: onerror],
- [Function: onError],
- [Function: onerror]
- ],
- finish: [
...
at Object.<anonymous> (/Users/runner/work/node/node/test/parallel/test-stream-duplex.js:159:10)
at Module._compile (node:internal/modules/cjs/loader:1568:14)
at Object..js (node:internal/modules/cjs/loader:1711:10)
at Module.load (node:internal/modules/cjs/loader:1328:32)
at Function._load (node:internal/modules/cjs/loader:1138:12)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5)
at node:internal/main/run_main_module:36:49 {
generatedMessage: false,
code: 'ERR_ASSERTION',
actual: Duplex {
_events: {
close: undefined,
error: undefined,
prefinish: undefined,
finish: undefined,
drain: undefined,
data: undefined,
end: undefined,
readable: undefined
},
_readableState: ReadableState {
highWaterMark: 65536,
buffer: [],
bufferIndex: 0,
length: 0,
pipes: [],
awaitDrainWriters: null,
[Symbol(kState)]: 1052940
},
_writableState: WritableState {
highWaterMark: 65536,
length: 0,
corked: 0,
onwrite: [Function: bound onwrite],
writelen: 0,
bufferedIndex: 0,
pendingcb: 0,
[Symbol(kState)]: 1093432076,
[Symbol(kBufferedValue)]: null
},
allowHalfOpen: true,
_maxListeners: undefined,
_read: [Function (anonymous)],
_destroy: [Function (anonymous)],
[Symbol(shapeMode)]: true,
[Symbol(kCapture)]: false
},
expected: Duplex {
_events: {
close: [
[Function (anonymous)],
[Function: onclose],
[Function (anonymous)],
[Function: bound onceWrapper] { listener: [Function: onclose] },
[Function: onclose]
],
error: [
[Function: onerror],
[Function: onerror],
[Function: onError],
[Function: onerror]
],
prefinish: undefined,
finish: [
[Function: onfinish],
[Function: bound onceWrapper] { listener: [Function: onfinish] },
[Function: onfinish]
],
drain: undefined,
data: undefined,
end: [ [Function: onend], [Function: onend], [Function (anonymous)] ],
readable: [Function (anonymous)],
unpipe: [Function: onunpipe]
},
_readableState: ReadableState {
highWaterMark: 65536,
buffer: [],
bufferIndex: 0,
length: 0,
pipes: [],
awaitDrainWriters: null,
[Symbol(kState)]: 9482508
},
_writableState: WritableState {
highWaterMark: 65536,
|
Test:
test/parallel/test-stream-filter.js#L13
--- stderr ---
node:stream:80
throw new ERR_INVALID_ARG_VALUE('result', result, 'must be a Duplex, Readable, or Writable stream');
^
TypeError [ERR_INVALID_ARG_VALUE]: The argument 'result' must be a Duplex, Readable, or Writable stream. Received Object [AsyncGenerator] {}
at Readable.filter (node:stream:80:11)
at Object.<anonymous> (/Users/runner/work/node/node/test/parallel/test-stream-filter.js:13:49)
at Module._compile (node:internal/modules/cjs/loader:1568:14)
at Object..js (node:internal/modules/cjs/loader:1711:10)
at Module.load (node:internal/modules/cjs/loader:1328:32)
at Function._load (node:internal/modules/cjs/loader:1138:12)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5)
at node:internal/main/run_main_module:36:49 {
code: 'ERR_INVALID_ARG_VALUE'
}
Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-stream-filter.js
|
Test:
test/parallel/test-stream-flatMap.js#L76
--- stderr ---
node:stream:80
throw new ERR_INVALID_ARG_VALUE('result', result, 'must be a Duplex, Readable, or Writable stream');
^
TypeError [ERR_INVALID_ARG_VALUE]: The argument 'result' must be a Duplex, Readable, or Writable stream. Received Object [AsyncGenerator] {}
at Readable.flatMap (node:stream:80:11)
at Object.<anonymous> (/Users/runner/work/node/node/test/parallel/test-stream-flatMap.js:76:27)
at Module._compile (node:internal/modules/cjs/loader:1568:14)
at Object..js (node:internal/modules/cjs/loader:1711:10)
at Module.load (node:internal/modules/cjs/loader:1328:32)
at Function._load (node:internal/modules/cjs/loader:1138:12)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5)
at node:internal/main/run_main_module:36:49 {
code: 'ERR_INVALID_ARG_VALUE'
}
Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-stream-flatMap.js
|
Test:
test/parallel/test-stream-forEach.js#L21
--- stderr ---
node:stream:80
throw new ERR_INVALID_ARG_VALUE('result', result, 'must be a Duplex, Readable, or Writable stream');
^
TypeError [ERR_INVALID_ARG_VALUE]: The argument 'result' must be a Duplex, Readable, or Writable stream. Received Object [AsyncGenerator] {}
at Readable.filter (node:stream:80:11)
at Object.<anonymous> (/Users/runner/work/node/node/test/parallel/test-stream-forEach.js:21:43)
at Module._compile (node:internal/modules/cjs/loader:1568:14)
at Object..js (node:internal/modules/cjs/loader:1711:10)
at Module.load (node:internal/modules/cjs/loader:1328:32)
at Function._load (node:internal/modules/cjs/loader:1138:12)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5)
at node:internal/main/run_main_module:36:49 {
code: 'ERR_INVALID_ARG_VALUE'
}
Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-stream-forEach.js
|
Test:
test/parallel/test-stream-map.js#L32
--- stderr ---
node:stream:80
throw new ERR_INVALID_ARG_VALUE('result', result, 'must be a Duplex, Readable, or Writable stream');
^
TypeError [ERR_INVALID_ARG_VALUE]: The argument 'result' must be a Duplex, Readable, or Writable stream. Received Object [AsyncGenerator] {}
at Readable.map (node:stream:80:11)
at Object.<anonymous> (/Users/runner/work/node/node/test/parallel/test-stream-map.js:32:49)
at Module._compile (node:internal/modules/cjs/loader:1568:14)
at Object..js (node:internal/modules/cjs/loader:1711:10)
at Module.load (node:internal/modules/cjs/loader:1328:32)
at Function._load (node:internal/modules/cjs/loader:1138:12)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5)
at node:internal/main/run_main_module:36:49 {
code: 'ERR_INVALID_ARG_VALUE'
}
Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-stream-map.js
|
Test:
test/parallel/test-stream-iterator-helpers-test262-tests.mjs#L1
--- stderr ---
node:stream:80
throw new ERR_INVALID_ARG_VALUE('result', result, 'must be a Duplex, Readable, or Writable stream');
^
TypeError [ERR_INVALID_ARG_VALUE]: The argument 'result' must be a Duplex, Readable, or Writable stream. Received Object [AsyncGenerator] {}
at Readable.drop (node:stream:80:11)
at file:///Users/runner/work/node/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs:62:42
at ModuleJob.run (node:internal/modules/esm/module_job:268:25)
at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:543:26)
at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:116:5) {
code: 'ERR_INVALID_ARG_VALUE'
}
Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs
|
Test:
test/parallel/test-stream-reduce.js#L56
--- stderr ---
node:stream:80
throw new ERR_INVALID_ARG_VALUE('result', result, 'must be a Duplex, Readable, or Writable stream');
^
TypeError [ERR_INVALID_ARG_VALUE]: The argument 'result' must be a Duplex, Readable, or Writable stream. Received Object [AsyncGenerator] {}
at Readable.map (node:stream:80:11)
at Object.<anonymous> (/Users/runner/work/node/node/test/parallel/test-stream-reduce.js:56:6)
at Module._compile (node:internal/modules/cjs/loader:1568:14)
at Object..js (node:internal/modules/cjs/loader:1711:10)
at Module.load (node:internal/modules/cjs/loader:1328:32)
at Function._load (node:internal/modules/cjs/loader:1138:12)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5)
at node:internal/main/run_main_module:36:49 {
code: 'ERR_INVALID_ARG_VALUE'
}
Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-stream-reduce.js
|
Test:
test/parallel/test-stream-toArray.js#L54
--- stderr ---
node:stream:80
throw new ERR_INVALID_ARG_VALUE('result', result, 'must be a Duplex, Readable, or Writable stream');
^
TypeError [ERR_INVALID_ARG_VALUE]: The argument 'result' must be a Duplex, Readable, or Writable stream. Received Object [AsyncGenerator] {}
at Readable.map (node:stream:80:11)
at /Users/runner/work/node/node/test/parallel/test-stream-toArray.js:50:42
at Object.<anonymous> (/Users/runner/work/node/node/test/parallel/test-stream-toArray.js:54:5)
at Module._compile (node:internal/modules/cjs/loader:1568:14)
at Object..js (node:internal/modules/cjs/loader:1711:10)
at Module.load (node:internal/modules/cjs/loader:1328:32)
at Function._load (node:internal/modules/cjs/loader:1138:12)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5) {
code: 'ERR_INVALID_ARG_VALUE'
}
Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-stream-toArray.js
|
Test:
test/parallel/test-stream-some-find-every.mjs#L12
--- stderr ---
node:stream:80
throw new ERR_INVALID_ARG_VALUE('result', result, 'must be a Duplex, Readable, or Writable stream');
^
TypeError [ERR_INVALID_ARG_VALUE]: The argument 'result' must be a Duplex, Readable, or Writable stream. Received Object [AsyncGenerator] {}
at Readable.map (node:stream:80:11)
at oneTo5Async (file:///Users/runner/work/node/node/test/parallel/test-stream-some-find-every.mjs:12:19)
at file:///Users/runner/work/node/node/test/parallel/test-stream-some-find-every.mjs:32:28
at process.processTicksAndRejections (node:internal/process/task_queues:105:5) {
code: 'ERR_INVALID_ARG_VALUE'
}
Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-stream-some-find-every.mjs
|
Post Set up sccache
0% - 0 hits, 0 misses, 0 errors
|
Loading