This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
build: add small-icu support for binary packages #8994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invokes the configure script used to build binary packages (OSX pkg, binary tarballs, pkgsrc, MSI) with --download=all --with-intl=small-icu. Also makes PACKAGEMAKER customizable, because PackageMaker is not necessarily installed in /Developer on OSX anymore. Tested all binary packages on Windows, OSX, Linux and SmartOS. Fixes nodejs#7676.
This was referenced Jan 8, 2015
|
intl part LGTM |
|
LGTM |
|
@srl295 @trevnorris Thanks for the review, landed in 67f87a7. |
|
That's great :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invokes the configure script used to build binary packages
(OSX pkg, binary tarballs, pkgsrc, MSI) with --download=all
--with-intl=small-icu.
Also makes PACKAGEMAKER customizable, because PackageMaker is not
necessarily installed in /Developer on OSX anymore.
Tested all binary packages on Windows, OSX, Linux and SmartOS.
Fixes #7676.