Removing bug from package name. #2211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package name as it currently stands is a racial slur that does not describe the project. Since the project is self-described in README.md as "Node.js native addon build tool", this commit changes all references to "nnabt" to remove the bug.
|
duplicate of #2168, please take discussion there, and changes to "gyp" should be directed to https://github.com/nodejs/gyp-next as we vendor in the gyp/ directory and no longer consider other edits to that directory |
|
This is incorrect. This is a PR, not just a feature request. Please reopen. |
|
Please isolate the changes in gyp/ from this PR, we don't accept changes to that directory here. Please also use #2168 to find resolution on this question. It's an ongoing discussion and while this might be a reasonable proposal, that's all it is and #2168 should be considered the place to find consensus. |
|
And for what it's worth in terms of consensus, I'm -1 on this change. |
|
Closing. Failing tests and too many conflicts. |
|
Not fixed. Package still racist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package name as it currently stands is a racial slur that does not
describe the project. Since the project is self-described in README.md as
"Node.js native addon build tool", this commit changes all references to
"nnabt" to remove the bug.
Checklist
npm install && npm testpassesDescription of change
Package name as it currently stands is a racial slur that does not
describe the project. Since the project is self-described in README.md as
"Node.js native addon build tool", this commit changes all references to
"nnabt" to remove the bug.