Skip to content

Commit

Permalink
Fix another occurrence. Use tuples for now, too
Browse files Browse the repository at this point in the history
  • Loading branch information
rzhao271 committed Aug 25, 2023
1 parent fabbc0b commit 51d02db
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pylib/gyp/generator/make.py
Original file line number Diff line number Diff line change
Expand Up @@ -2028,7 +2028,7 @@ def WriteTarget(
installable_deps.append(
self.GetUnversionedSidedeckFromSidedeck(install_path)
)
if self.output != self.alias and self.alias != self.target:
if self.alias not in (self.output, self.target):
self.WriteMakeRule(
[self.alias],
installable_deps,
Expand Down
2 changes: 1 addition & 1 deletion pylib/gyp/xcodeproj_file.py
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,7 @@ def __init__(self, properties=None, id=None, parent=None):
if "path" in self._properties and "name" not in self._properties:
path = self._properties["path"]
name = posixpath.basename(path)
if name not in {"", path}:
if name not in ("", path):
self.SetProperty("name", name)

if "path" in self._properties and (
Expand Down

0 comments on commit 51d02db

Please sign in to comment.