Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: skip coffeescript #1081

Merged
merged 1 commit into from
Dec 23, 2024
Merged

lookup: skip coffeescript #1081

merged 1 commit into from
Dec 23, 2024

Conversation

targos
Copy link
Member

@targos targos commented Dec 21, 2024

No description provided.

@RafaelGSS
Copy link
Member

cc: @jashkenas @GeoffreyBooth

@GeoffreyBooth
Copy link
Member

So the referenced PR, jashkenas/coffeescript#5478, disables some import assertion tests and some error stack trace tests. I think the former should be fixed by changing assert to with; but the latter might be a real issue. I don’t know why --enable-source-maps would have worked previously for CoffeeScript but be broken now.

@targos
Copy link
Member Author

targos commented Dec 23, 2024

In any case, this has to be fixed in the coffeescript package. In the mean time, we skip it to reduce the noise for releasers.

@targos targos merged commit 463f500 into nodejs:main Dec 23, 2024
14 checks passed
@targos targos deleted the skip-coffee branch December 23, 2024 08:39
@GeoffreyBooth
Copy link
Member

I'm saying that the source maps one is possibly a bug in Node. Nothing changed on the CoffeeScript side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants