Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jenkins: cleanup VersionSelectorScript.groovy #3447

Merged
merged 1 commit into from
Aug 11, 2023
Merged

jenkins: cleanup VersionSelectorScript.groovy #3447

merged 1 commit into from
Aug 11, 2023

Conversation

targos
Copy link
Member

@targos targos commented Aug 10, 2023

  • Remove lines that only exclude EoL versions
  • Reference currently supported versions everywhere

@targos
jenkins: cleanup VersionSelectorScript.groovy
3081817 
- Remove lines that only exclude EoL versions
- Reference currently supported versions everywhere
MoLow
MoLow approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@targos targos merged commit 7b5d0a4 into nodejs:main Aug 11, 2023
@targos targos deleted the cleanup-selector branch August 11, 2023 06:23
@rvagg
Copy link
Member

rvagg commented Aug 11, 2023

wow .. so much history in there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@richardlau richardlau richardlau approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @rvagg @UlisesGascon @richardlau @MoLow