Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native URL methods for appending the query params #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use native URL methods for appending the query params #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4230dfa
Use native URL methods for appending the query params
kasparsd Oct 4, 2018
ba2bde9
Fix reference
kasparsd Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/AuthenticationRequest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ const assert = require('assert')
const base64url = require('base64url')
const crypto = require('@trust/webcrypto')
const { JWT } = require('@solid/jose')
const FormUrlEncoded = require('./FormUrlEncoded')
const { URL } = require('whatwg-url')

/**
Expand Down Expand Up @@ -117,7 +116,9 @@ class AuthenticationRequest {
// render the request URI and terminate the algorithm
.then(() => {
let url = new URL(endpoint)
url.search = FormUrlEncoded.encode(params)

// combine with any exists query parameters.
Object.entries(params).map(param => url.searchParams.append(param[0], param[1]))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like URLSearchParams encodes it like response_type=id_token+token instead of response_type=id_token%20token. Should be OK per https://stackoverflow.com/a/1211261 or do we need RFC 1738?


return url.href
})
Expand Down