Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic prep fix 1 #1801

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Basic prep fix 1 #1801

wants to merge 6 commits into from

Commits on Nov 8, 2024

  1. fix: Use XML Date Format in Notifications

    Using XML Date format instead of Internet Date format for Solid-PREP Notifications.
    CxRes committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    fef1ea2 View commit details
    Browse the repository at this point in the history
  2. fix: Swapped object and target/origin in Notifications

    Swapped the `object` and `target`/`origin` properties in case of `Add`/`Delete` notifications respectively.
    CxRes committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    ad7073b View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. fix: Notification Templates

    + Notifications are identified by UUIDs.
    + Turtle notification template has the same fields as JSON-LD.
    + `notify:state` transmits Event-ID (which uniquely identifies a resource's state) and not E-Tag (which identify representations of the resource).
    + Parent reuses the generated Event-ID.
    CxRes committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    c33bc32 View commit details
    Browse the repository at this point in the history
  2. feat/refactor: Event-ID Generated for Notifications Only

    + Event-ID is generated in PREP notification middleware itself.
    + No longer setting `Event-ID` response header upon resource mutation, thus reverting the middlewares for unsafe methods to their original state, before PREP was introduced.
    CxRes committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    6c31436 View commit details
    Browse the repository at this point in the history
  3. chore: Ensure CI runs Node 20

    Change the CI node-version to use caret range to ensure that tests are run on Node.js v20.
    CxRes committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    d6a992f View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. fix: Wrap IRIs in <> in Turtle Notification Templete

    Values for `as:object`, `as:target` and `as:origin` predicates in the Turtle PREP-Notification template are IRI's, so they must be wrapped in angle brackets.
    
    Co-authored-by: Sarven Capadisli <[email protected]>
    CxRes and csarven authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d86d150 View commit details
    Browse the repository at this point in the history