-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic prep fix 1 #1801
Open
bourgeoa
wants to merge
6
commits into
main
Choose a base branch
from
basic-prep-fix-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Basic prep fix 1 #1801
Commits on Nov 8, 2024
-
fix: Use XML Date Format in Notifications
Using XML Date format instead of Internet Date format for Solid-PREP Notifications.
Configuration menu - View commit details
-
Copy full SHA for fef1ea2 - Browse repository at this point
Copy the full SHA fef1ea2View commit details -
fix: Swapped
object
andtarget
/origin
in NotificationsSwapped the `object` and `target`/`origin` properties in case of `Add`/`Delete` notifications respectively.
Configuration menu - View commit details
-
Copy full SHA for ad7073b - Browse repository at this point
Copy the full SHA ad7073bView commit details
Commits on Nov 10, 2024
-
+ Notifications are identified by UUIDs. + Turtle notification template has the same fields as JSON-LD. + `notify:state` transmits Event-ID (which uniquely identifies a resource's state) and not E-Tag (which identify representations of the resource). + Parent reuses the generated Event-ID.
Configuration menu - View commit details
-
Copy full SHA for c33bc32 - Browse repository at this point
Copy the full SHA c33bc32View commit details -
feat/refactor: Event-ID Generated for Notifications Only
+ Event-ID is generated in PREP notification middleware itself. + No longer setting `Event-ID` response header upon resource mutation, thus reverting the middlewares for unsafe methods to their original state, before PREP was introduced.
Configuration menu - View commit details
-
Copy full SHA for 6c31436 - Browse repository at this point
Copy the full SHA 6c31436View commit details -
Change the CI node-version to use caret range to ensure that tests are run on Node.js v20.
Configuration menu - View commit details
-
Copy full SHA for d6a992f - Browse repository at this point
Copy the full SHA d6a992fView commit details
Commits on Nov 11, 2024
-
fix: Wrap IRIs in <> in Turtle Notification Templete
Values for `as:object`, `as:target` and `as:origin` predicates in the Turtle PREP-Notification template are IRI's, so they must be wrapped in angle brackets. Co-authored-by: Sarven Capadisli <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d86d150 - Browse repository at this point
Copy the full SHA d86d150View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.