Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append patch new document #1745

Merged
merged 29 commits into from
Dec 17, 2023
Merged

Append patch new document #1745

merged 29 commits into from
Dec 17, 2023

Conversation

bourgeoa
Copy link
Member

This allow to PATCH a new document with Append only.

@bourgeoa bourgeoa linked an issue Nov 30, 2023 that may be closed by this pull request
PATCH do not allow to create new file with APPEND #1731
Closed
@csarven
Copy link
Member

csarven commented Nov 30, 2023

Not sure I understand. To create a new resource (C/R) with PATCH (as with PUT) requires Append (or Write) on C/ and Write on C/R.

This was referenced Nov 30, 2023
Open
Open
TallTed
TallTed reviewed Nov 30, 2023
View reviewed changes
lib/handlers/patch.js Outdated Show resolved Hide resolved
@bourgeoa
Copy link
Member Author

Not sure I understand. To create a new resource (C/R) with PATCH (as with PUT) requires Append (or Write) on C/ and Write on C/R.

A very fat finger .....

1 similar comment
@bourgeoa
Copy link
Member Author

Not sure I understand. To create a new resource (C/R) with PATCH (as with PUT) requires Append (or Write) on C/ and Write on C/R.

A very fat finger .....

bourgeoa and others added 17 commits November 30, 2023 20:41
@bourgeoa @TallTed
Update test/integration/acl-oidc-test.js
e14e5f0 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@bourgeoa @TallTed
Update test/integration/acl-oidc-test.js
173ecb7 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@bourgeoa
node14 & 16
6129eb9
@bourgeoa
Merge branch 'appendPatchNewDocument' of https://github.com/solid/nod…
c71eb27 
…e-solid-server into appendPatchNewDocument
@bourgeoa
update test-suite
44bfd13
@bourgeoa
Merge branch 'main' into appendPatchNewDocument
f243c66
@bourgeoa
node 18 defaults to ipv6
ae9cfd8
@bourgeoa
Merge branch 'appendPatchNewDocument' of https://github.com/solid/nod…
649901c 
…e-solid-server into appendPatchNewDocument
@bourgeoa
clean runTests line
b71c107
@bourgeoa
test branch
5080f6f
@bourgeoa
nss-skips
dfcf617
@bourgeoa
use test branch
c5ccf90
@bourgeoa
use https
94bb321
@bourgeoa
remove ftech branch
59b22da
@bourgeoa
add git pull
6c5edcd
@bourgeoa
git pull https
65ebc1c
@bourgeoa
git stash
c200a01
@bourgeoa bourgeoa merged commit acf53e5 into main Dec 17, 2023
3 checks passed
@bourgeoa bourgeoa deleted the appendPatchNewDocument branch February 11, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PATCH do not allow to create new file with APPEND
3 participants
@bourgeoa @csarven @TallTed