Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --link option as is deprecated #201

Merged
merged 11 commits into from
Oct 1, 2020
Merged

Conversation

binnes
Copy link

@binnes binnes commented Sep 23, 2020

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Fixes issue #200, which is about the use of the Docker --link option, which is now deprecated. This fix updates the project README to use a Docker user-defined bridge to allow containers to communicate rather than the --link option.

Also linked to documentation issue node-red/node-red.github.io#186, as information from this page is duplicated in the Node-RED documentation

Checklist

  • [ x] I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@dceejay dceejay changed the base branch from master to dev September 23, 2020 14:06
@dceejay
Copy link
Member

dceejay commented Sep 23, 2020

Want to re-target this to dev branch as that has all the VOLUME change in as well...

@dceejay dceejay merged commit d465089 into node-red:dev Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants