WIP: Move unsupported platform failure from os.name to separate method. #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we've accidentally depended on the isWindows check to see if we're on a supported platform or not, this had the unfortunate side-effect that even with `download = false` we triggered the error(). See #178
deepy
commented
Jul 4, 2021
| name.contains("sunos") -> "sunos" | ||
| else -> error("Unsupported OS: $name") | ||
| else -> "unsupported" |
There was a problem hiding this comment.
I don't really like this since if we're extending this or someone uses their own distribution URL which does have binaries it's going to fail, and we're providing no way to override it.
|
Hmm, this wasn't enough, there's still issues |
This is not ideal since even if `download = true` there could very well be builds that work fine, especially if you're excluding the tasks from the node plugin. But right now there's harder to diagnose errors appearing further down the line and this should make for a more stable build, at least an overall more stable build.
|
this work isn't abandoned, but currently it looks like it might be easier to solve in a different way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we've accidentally depended on the
isWindowscheck to see if we're on a supported platform or not, this had the unfortunate side-effect that even withdownload = falsewe triggered the error()I've moved this to
PlatformHelper.failIfUnsupportedPlatform()