Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration externalization #33

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Configuration externalization #33

wants to merge 4 commits into from

Conversation

juliendangers
Copy link
Contributor

@juliendangers juliendangers commented Jun 8, 2016

To avoid having to create a specific file for each environment, and to be able to deploy multiple freight-server instances with different configurations, it is easier to be able to provide configuration from environment variables. It is also easier to use with docker

I still need to find a way to extract redis options, but file can used for that at the moment.

I still need to update README to explain password is empty by default, and I may need to update tests accordingly (I'll do it today).

@vladikoff
Copy link
Member

Anything else you wanted in this PR? Redis config?

@juliendangers
Copy link
Contributor Author

@vladikoff do you think it's a good idea to drop automatic password generation ? Shouldn't we generate one if not set in env variable or configuration file ?

@vladikoff
Copy link
Member

@vladikoff do you think it's a good idea to drop automatic password generation ? Shouldn't we generate one if not set in env variable or configuration file ?

Yeah I like the functionality, can we keep it?

@juliendangers
Copy link
Contributor Author

👍 I could try to generate a new password if it's not set through env variable or configuration file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants