Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize KVCache page_tables to zero to prevent NaNs #833

Closed
wants to merge 2 commits into from
Closed

Initialize KVCache page_tables to zero to prevent NaNs #833

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0fb408
Initialize KVCache `page_tables` to zero to prevent NaNs being introd…
stbaione Jan 16, 2025
56261dc
Merge branch 'main' into sharded-kvcache-fix
stbaione Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions shortfin/python/shortfin_apps/llm/components/kvcache/page_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ def __init__(self, *, devices: Sequence[sf.ScopedDevice], config: PagePoolConfig
page_table = sf.array.device_array.for_device(
device, page_table_shape, self.config.dtype
)
page_table_host = page_table.for_transfer()
with page_table_host.map(discard=True) as m:
m.fill(0)
page_table_host.copy_to(page_table)
self.page_tables.append(page_table)

def acquire_free_pages(self, count: int) -> list[PageInfo] | None:
Expand Down
Loading