[llama] Generate causal mask better #832
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the causal mask was being generated as::
This is not a good thing to do. This is simply making it harder for the compiler to fuse this "fill like" computation to a dispatch. The slicing with a dynamic dimension is harder to move around.
Instead, it's a better idea to generate the attention mask as:
This PR also removes the ability to put the mask in a buffer. This is again a really bad idea. The causal mask computation should never actually materialize outside a dispatch. If the compiler fails to do this, we should see memory usage spikes and fix the compiler.