Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tuner] Fix context management #770

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Conversation

bangtianliu
Copy link
Contributor

@bangtianliu bangtianliu commented Jan 7, 2025

This PR is about addressing the MLIR context management issue in the tuner detailed in #764.

Although this is a work in progress, I am sending it to gather feedback and ensure I am heading in the right direction.

@bangtianliu bangtianliu requested review from kuhar and Max191 January 7, 2025 06:34
tuner/tuner/libtuner.py Outdated Show resolved Hide resolved
tuner/examples/dispatch/dispatch_tuner.py Outdated Show resolved Hide resolved
tuner/tuner/common.py Outdated Show resolved Hide resolved
@bangtianliu bangtianliu requested a review from kuhar January 7, 2025 19:55
@bangtianliu bangtianliu changed the title [tuner] context management [tuner] fix context management Jan 7, 2025
@bangtianliu bangtianliu changed the title [tuner] fix context management [Tuner] Fix context management Jan 7, 2025
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this on top of #771 ?

tuner/examples/test/tuner_test.py Outdated Show resolved Hide resolved
tuner/tuner/candidate_gen_test.py Outdated Show resolved Hide resolved
tuner/tuner/common.py Outdated Show resolved Hide resolved
tuner/tuner/common.py Outdated Show resolved Hide resolved
tuner/tuner/common.py Outdated Show resolved Hide resolved
tuner/tuner/common.py Outdated Show resolved Hide resolved
tuner/tuner/common_test.py Outdated Show resolved Hide resolved
tuner/tuner/dispatch_constraints_test.py Outdated Show resolved Hide resolved
tuner/tuner/dispatch_parser_test.py Outdated Show resolved Hide resolved
tuner/tuner/libtuner.py Outdated Show resolved Hide resolved
@bangtianliu bangtianliu force-pushed the context_handle branch 4 times, most recently from f668377 to 9eed59b Compare January 7, 2025 21:33
@bangtianliu bangtianliu requested a review from kuhar January 7, 2025 21:36
@bangtianliu
Copy link
Contributor Author

bangtianliu commented Jan 7, 2025

There are some local pytest errors and I am working on them, will send another commit after addressing them.

@bangtianliu bangtianliu force-pushed the context_handle branch 3 times, most recently from d7ff2a9 to 139c4dd Compare January 8, 2025 00:10
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % one minor issue

tuner/tuner/common.py Outdated Show resolved Hide resolved
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
@bangtianliu bangtianliu merged commit ed7906f into nod-ai:main Jan 8, 2025
23 of 25 checks passed
monorimet pushed a commit that referenced this pull request Jan 8, 2025
This PR is about addressing the MLIR context management issue in the
tuner detailed in #764.

Although this is a work in progress, I am sending it to gather feedback
and ensure I am heading in the right direction.

---------

Signed-off-by: Bangtian Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants