Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop path filters from shortfin and SDXL CI workflows. #759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop path filters from shortfin and SDXL CI workflows. #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/ci-sdxl.yaml
View file
Open in desktop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't particularly resource constrained and I'd rather have continuous signal for these workflows.

Hmm... well, since this workflow has runs-on: mi300x-4, it's been queued for 20 minutes, currently stuck behind https://github.com/nod-ai/shark-ai/actions/runs/12637108441/job/35210632193.

I wonder if this can just on any mi300, or if it needs that specific runner. I see we have a bunch of runners with different labels in this repository. Can we consolidate some labels to be able to request just "any MI300"?

@saienduri @amd-chrissosa @yamiyysu

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a lot of context on this specific workflow but theoretically any workload without heavy storage/networking requirements that needs a MI300x should be able to be migrated to what @yamiyysu is porting.

Copy link
Contributor

@saienduri saienduri Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should be able to port this one with no problem. Also, we can consolidate all 3 of our lab machines onto the same mi300 label. Are all the hardcoded paths in workflow files consistent across lab machines? @archana-ramalingam @aviator19941

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On MI300x-1, weights are at /data/llama3.1/weights/8b, MI300x-3, they are at /data/llama3.1/8b. We need to make this consistent across all systems.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no hardcoded paths. Everything should use environment variables and cache directories, with scripts being used to populate the cache on any machine as needed.

Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,9 @@ name: CI - shortfin - SDXL
on:
workflow_dispatch:
pull_request:
paths:
- '.github/workflows/ci-sdxl.yaml'
- 'shortfin/**'
push:
branches:
- main
paths:
- '.github/workflows/ci-sdxl.yaml'
- 'shortfin/**'

permissions:
contents: read
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/ci_linux_x64_asan-libshortfin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,9 @@ name: CI - shortfin - ASan
on:
workflow_dispatch:
pull_request:
paths:
- '.github/workflows/ci_linux_x64_asan-libshortfin.yml'
- 'shortfin/**'
push:
branches:
- main
paths:
- '.github/workflows/ci_linux_x64_asan-libshortfin.yml'
- 'shortfin/**'

permissions:
contents: read
Expand Down
7 changes: 0 additions & 7 deletions .github/workflows/ci_linux_x64_nogil-libshortfin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,9 @@ name: CI - shortfin - Python 3.13 Free-threaded
on:
workflow_dispatch:
pull_request:
paths:
- '.github/workflows/ci_linux_x64-libshortfin.yml'
- 'shortfin/**'

push:
branches:
- main
paths:
- '.github/workflows/ci_linux_x64-libshortfin.yml'
- 'shortfin/**'

permissions:
contents: read
Expand Down
Loading