Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iree_hal_buffer_subspan after change in iree. #671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

Fix iree_hal_buffer_subspan after change in iree. #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shortfin/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ if(NOT WIN32)
endif()

# Pins
set(SHORTFIN_IREE_GIT_TAG "iree-3.1.0rc20241204")
set(SHORTFIN_IREE_GIT_TAG "iree-3.1.0rc20241211")

# build options
option(SHORTFIN_BUILD_PYTHON_BINDINGS "Builds Python Bindings" OFF)
Expand Down
4 changes: 2 additions & 2 deletions shortfin/requirements-iree-compiler.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Keep in sync with "ref: iree-" in .github/workflows/* and GIT_TAG in CMakeLists.txt
-f https://iree.dev/pip-release-links.html
iree-base-compiler==3.1.0rc20241204
iree-base-runtime==3.1.0rc20241204
iree-base-compiler==3.1.0rc20241211
iree-base-runtime==3.1.0rc20241211
4 changes: 3 additions & 1 deletion shortfin/src/shortfin/array/storage.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ storage storage::subspan(iree_device_size_t byte_offset,
iree_device_size_t byte_length) {
storage new_storage(device_, {}, timeline_resource_);
SHORTFIN_THROW_IF_ERROR(iree_hal_buffer_subspan(
buffer_, byte_offset, byte_length, new_storage.buffer_.for_output()));
buffer_, byte_offset, byte_length,
iree_hal_device_host_allocator(device_.raw_device()->hal_device()),
new_storage.buffer_.for_output()));
return new_storage;
}

Expand Down
Loading