(shortfin-sd) Interleave workers and their fibers by device. #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monorimet
changed the title
|
Thanks for this patch. So with this can we run SDXL on CPX mode leveraging all the nodes? It would be helpful to add what this addresses in PR description |
|
verified and example is working |
IanNod
approved these changes
Jan 7, 2025
monorimet
added a commit
that referenced
this pull request
Jan 8, 2025
This enables proper "filling" of multi-device topologies that populate each device evenly, rather than block allocating work to one device at a time. Co-authored-by: Ean Garvey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables proper "filling" of multi-device topologies that populate each device evenly, rather than block allocating work to one device at a time.