Fix fixture,

Update test ids
nod-ai · Jan 24, 2025 · 7e9bb31 · 7e9bb31
1 parent 086b757
commit 7e9bb31
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/app_tests/integration_tests/llm/shortfin/conftest.py b/app_tests/integration_tests/llm/shortfin/conftest.py
@@ -93,7 +93,7 @@ def server(model_artifacts, request):
     process.wait()
 
 
-@pytest.fixture(scope="function")
-def encoded_prompt(model_artifacts: ModelArtifacts, prompt: str) -> list[int]:
+@pytest.fixture(scope="module")
+def encoded_prompt(model_artifacts: ModelArtifacts, request) -> list[int]:
     tokenizer = Tokenizer.from_file(model_artifacts.tokenizer_path)
-    return tokenizer.encode(prompt).ids
+    return tokenizer.encode(request.param).ids
diff --git a/app_tests/integration_tests/llm/shortfin/cpu_llm_server_test.py b/app_tests/integration_tests/llm/shortfin/cpu_llm_server_test.py
@@ -109,10 +109,10 @@ def test_basic_generation(self, server: tuple[Any, int]) -> None:
             ),
         ],
         ids=[
-            "open_llama_3b_none",
-            "open_llama_3b_trie",
-            "llama31_8b_none",
-            "llama31_8b_trie",
+            "open_llama_3b_none_input_ids",
+            "open_llama_3b_trie_input_ids",
+            "llama31_8b_none_input_ids",
+            "llama31_8b_trie_input_ids",
         ],
         indirect=True,
     )