Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 docker support rocm #33

Closed
wants to merge 1 commit into from
Closed

4 docker support rocm #33

wants to merge 1 commit into from

Conversation

jakki-amd
Copy link
Collaborator

Description

Dockerfile and build_image.sh don't currently have support for ROCm. This PR add support for ROCM in official Dockerifile.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Copy link
Collaborator

@smedegaard smedegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jakki-amd jakki-amd force-pushed the 4-docker-support-rocm branch from d37ed5c to a580bca Compare January 2, 2025 15:24
@jakki-amd jakki-amd force-pushed the 4-docker-support-rocm branch from 13bfd70 to 1f1ad0b Compare January 7, 2025 09:11
@jakki-amd jakki-amd closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants