-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some improvements #4
Open
jerryrt
wants to merge
7
commits into
noahsw:master
Choose a base branch
from
jerryrt:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2ff8dbc
adding new tracking API from Google Analytics.
f46cedb
enhance README
e15e92d
adding new tracking API from Google Analytics.
e9814a2
fix threading issue.
a65b6b9
don't read bundle on every request.
398a2e7
fix project configuration when build as sub project and bundle the li…
1486f29
correct a typo
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
Google Analytics SDK for OSX/Classes/GoogleUniversalTracking.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // | ||
| // GoogleMeasurementProtocolEvent.h | ||
| // Google Analytics SDK for OSX | ||
| // | ||
| // Created by Jerry Tian on 3/25/13. | ||
| // Copyright (c) 2013 Noah Spitzer-Williams. All rights reserved. | ||
| // | ||
|
|
||
| #import <Foundation/Foundation.h> | ||
| #import "TrackingRequest.h" | ||
|
|
||
| @interface GoogleUniversalTracking : NSOperation | ||
|
|
||
| @property (strong) TrackingRequest* request; | ||
|
|
||
| @end |
79 changes: 79 additions & 0 deletions
79
Google Analytics SDK for OSX/Classes/GoogleUniversalTracking.m
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| // | ||
| // GoogleMeasurementProtocolEvent.m | ||
| // Google Analytics SDK for OSX | ||
| // | ||
| // Created by Jerry Tian on 3/25/13. | ||
| // Copyright (c) 2013 Noah Spitzer-Williams. All rights reserved. | ||
| // | ||
|
|
||
| #import "GoogleUniversalTracking.h" | ||
| #import "PublicIP.h" | ||
| #import "JFUrlUtil.h" | ||
|
|
||
| #import "DDLog.h" | ||
| static const int ddLogLevel = LOG_LEVEL_VERBOSE | LOG_LEVEL_INFO | LOG_LEVEL_ERROR | LOG_LEVEL_WARN; | ||
|
|
||
| @implementation GoogleUniversalTracking | ||
|
|
||
|
|
||
| - (void) main { | ||
| if ([NSThread isMainThread]) { | ||
| [self performSelectorInBackground:@selector(main) withObject:nil]; | ||
| return; | ||
| } | ||
|
|
||
| [NSThread setThreadPriority:0.1]; | ||
| [NSThread sleepForTimeInterval:1]; | ||
|
|
||
| static NSString* analyticsAccountCode = nil; | ||
| if (analyticsAccountCode == nil) { | ||
| NSBundle* mainBundle = [NSBundle mainBundle]; | ||
| #if DEBUG | ||
| analyticsAccountCode = [mainBundle objectForInfoDictionaryKey:@"Google Analytics ID (Debug)"]; | ||
| #else | ||
| analyticsAccountCode = [mainBundle objectForInfoDictionaryKey:@"Google Analytics ID (Release)"]; | ||
| #endif | ||
| } | ||
|
|
||
| NSAssert(analyticsAccountCode!=nil, @"analyticsAccountCode can not be nil, set it in your info.plist."); | ||
|
|
||
| //the origin author using the fields this way: | ||
| //label => client UUID | ||
| //category => client version | ||
| //action => event name | ||
| //value => event value(number) | ||
| GoogleEvent * event = self.request.trackingEvent; | ||
|
|
||
|
|
||
| GoogleEvent* trackingEvent = [self.request trackingEvent]; | ||
| //see "Event tracking para": | ||
| //https://developers.google.com/analytics/devguides/collection/protocol/v1/devguide | ||
| NSString * payload = [NSString stringWithFormat:@"v=1&tid=%@&cid=%@&t=event&ec=%@&ea=%@&el=%@&ev=%@", | ||
| analyticsAccountCode, | ||
| [JFUrlUtil encodeUrl:event.label], | ||
| [JFUrlUtil encodeUrl:event.category], | ||
| [JFUrlUtil encodeUrl:event.action], | ||
| @"", | ||
| event.val | ||
| ]; | ||
|
|
||
|
|
||
|
|
||
|
|
||
| @try { | ||
| NSMutableURLRequest *request = [[NSMutableURLRequest alloc] initWithURL:[NSURL URLWithString: @"http://www.google-analytics.com/collect"]]; | ||
| [request setHTTPMethod:@"POST"]; | ||
| [request setValue:@"application/x-www-form-urlencoded" forHTTPHeaderField:@"content-type"]; | ||
| [request setHTTPBody:[payload dataUsingEncoding: NSUTF8StringEncoding]]; | ||
| NSData *returnData = [NSURLConnection sendSynchronousRequest: request returningResponse: nil error: nil]; | ||
|
|
||
| if (returnData && [returnData length] > 0) | ||
| DDLogInfo(@"Analytics event (%@, %@, %@, %@): triggered successfully!", [trackingEvent category], [trackingEvent action], [trackingEvent label], [trackingEvent val]); | ||
| else | ||
| DDLogInfo(@"Analytics event (%@, %@, %@, %@): trigger error", [trackingEvent category], [trackingEvent action], [trackingEvent label], [trackingEvent val]); | ||
| } | ||
| @catch (NSException *exception) { | ||
| DDLogInfo(@"Analytics event (%@, %@, %@, %@): exception thrown %@", [trackingEvent category], [trackingEvent action], [trackingEvent label], [trackingEvent val], exception); | ||
| } | ||
| } | ||
| @end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a typo here, measureEvent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I will correct the typo.