Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

Enactment states column #83

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

upalatucci
Copy link
Collaborator

Change the column title from 'Node network state' to 'Enactment states' as the filter in the toolbar is called this way.

Screenshot from 2023-10-24 13-02-17

Copy link
Collaborator

@hstastna hstastna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @upalatucci , I can see in the screenshot the filter in the toolbar is called "Enactment state". However you used plural for the new column title. Maybe we could make it consistent in the both places? It would look better, it is a little change. Also I can see the original column name also uses singular, not plural. So maybe singular is the right form of the word "state"...

@upalatucci
Copy link
Collaborator Author

upalatucci commented Oct 24, 2023

Yeah, it's challenging to choose what to put here. I put plural in the column as for each column we have multiple enactments but in the filter, it does make sense to use singular as we use singular here every time.

@hstastna
Copy link
Collaborator

hstastna commented Oct 24, 2023

Hmm, now it makes more sense to me to use plural in both places. Because when filtering, you also can filter more states, and the result of filtering can also be more states.
Another option to solve this is to ask someone from UX or doc team, to make sure about the correct form/forms used in both places.

@upalatucci
Copy link
Collaborator Author

let's use the plural for both. If someone complain, we can change that

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 8d2befa into nmstate:main Oct 27, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants