Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

New nodejs base image #81

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

upalatucci
Copy link
Collaborator

@upalatucci upalatucci commented Oct 20, 2023

New base docker image is behind authentication so we cannot have a docker build on ci.
I tested the image locally and it works. If we need the docker build we could rely on the nightly build.

The build can be done locally following this documentation page

https://docs.ci.openshift.org/docs/how-tos/use-registries-in-build-farm/#how-do-i-log-in-to-pull-images-that-require-authentication

There is no need for a registry now in the ci cluster ....

@upalatucci upalatucci force-pushed the nodejs-base-4.15-image branch 15 times, most recently from 5532f57 to b99e223 Compare October 23, 2023 10:14
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit b2e2d6d into nmstate:main Oct 23, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants