Skip to content

Commit

Permalink
Rename flag, use class name to access static variables
Browse files Browse the repository at this point in the history
  • Loading branch information
dyashuni committed Aug 13, 2023
1 parent e023f7e commit eecd540
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,18 +73,18 @@ def cpp_flag(compiler):

class BuildExt(build_ext):
"""A custom build extension for adding compiler-specific options."""
native_flag = '-march=native'
compiler_flag_native = '-march=native'
c_opts = {
'msvc': ['/EHsc', '/openmp', '/O2'],
'unix': ['-O3', native_flag], # , '-w'
'unix': ['-O3', compiler_flag_native], # , '-w'
}
link_opts = {
'unix': [],
'msvc': [],
}

if os.environ.get("HNSWLIB_NO_NATIVE"):
c_opts['unix'].remove(native_flag)
c_opts['unix'].remove(compiler_flag_native)

if sys.platform == 'darwin':
c_opts['unix'] += ['-stdlib=libc++', '-mmacosx-version-min=10.7']
Expand All @@ -95,18 +95,18 @@ class BuildExt(build_ext):

def build_extensions(self):
ct = self.compiler.compiler_type
opts = self.c_opts.get(ct, [])
opts = BuildExt.c_opts.get(ct, [])
if ct == 'unix':
opts.append('-DVERSION_INFO="%s"' % self.distribution.get_version())
opts.append(cpp_flag(self.compiler))
if has_flag(self.compiler, '-fvisibility=hidden'):
opts.append('-fvisibility=hidden')
if not os.environ.get("HNSWLIB_NO_NATIVE"):
# check that native flag is available
print('checking avalability of flag:', self.native_flag)
if not has_flag(self.compiler, self.native_flag):
print('removing unsupported compiler flag:', self.native_flag)
opts.remove(self.native_flag)
print('checking avalability of flag:', BuildExt.compiler_flag_native)
if not has_flag(self.compiler, BuildExt.compiler_flag_native):
print('removing unsupported compiler flag:', BuildExt.compiler_flag_native)
opts.remove(BuildExt.compiler_flag_native)
# for macos add apple-m1 flag if it's available
if sys.platform == 'darwin':
m1_flag = '-mcpu=apple-m1'
Expand All @@ -117,13 +117,13 @@ def build_extensions(self):
else:
print(f'flag: {m1_flag} is not available')
else:
print(f'flag: {self.native_flag} is available')
print(f'flag: {BuildExt.compiler_flag_native} is available')
elif ct == 'msvc':
opts.append('/DVERSION_INFO=\\"%s\\"' % self.distribution.get_version())

for ext in self.extensions:
ext.extra_compile_args.extend(opts)
ext.extra_link_args.extend(self.link_opts.get(ct, []))
ext.extra_link_args.extend(BuildExt.link_opts.get(ct, []))

build_ext.build_extensions(self)

Expand Down

0 comments on commit eecd540

Please sign in to comment.