Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relationships peerDeletionInfo contains _deletionStatus instead of deletionStatus #285

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Relationships peerDeletionInfo contains _deletionStatus instead of deletionStatus #285

merged 2 commits into from
Sep 25, 2024

Conversation

jkoenig134
Copy link
Member

@jkoenig134 jkoenig134 commented Sep 25, 2024 •
edited
Loading

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@jkoenig134 jkoenig134 changed the title Relationships peerDeletionInfo contains _ Relationships peerDeletionInfo contains _deletionStatus instead of deletionStatus Sep 25, 2024
@jkoenig134 jkoenig134 added the bug Something isn't working label Sep 25, 2024
@jkoenig134 jkoenig134 marked this pull request as ready for review September 25, 2024 09:06
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...ases/transport/relationships/RelationshipMapper.ts 92.00% <100.00%> (ø)
...rc/modules/relationships/local/PeerDeletionInfo.ts 100.00% <100.00%> (ø)

@Siolto
Copy link
Contributor

Siolto commented Sep 25, 2024

FYI: @aince42

@jkoenig134 jkoenig134 changed the title Relationships peerDeletionInfo contains _deletionStatus instead of deletionStatus Relationships peerDeletionInfo contains _deletionStatus instead of deletionStatus Sep 25, 2024
@jkoenig134 jkoenig134 enabled auto-merge (squash) September 25, 2024 09:11
@jkoenig134 jkoenig134 merged commit 0c84d77 into main Sep 25, 2024
18 of 19 checks passed
@jkoenig134 jkoenig134 deleted the use-tojson-for-PeerDeletionInfo branch September 25, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siolto Siolto Siolto approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoenig134 @Siolto