Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove object loading by id and key #281

Merged
merged 13 commits into from
Sep 23, 2024

Conversation

jkoenig134
Copy link
Member

@jkoenig134 jkoenig134 commented Sep 23, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Description

When loading objects was introduced this was the main way to do it. As we now introduce personalized and password protected objects loading by id and key becomes very unsafe.

This will result in runtime@v6.

@jkoenig134 jkoenig134 changed the title Refactor/remove object loading by id and key Remove object loading by id and key Sep 23, 2024
@jkoenig134 jkoenig134 added the refactoring Refactoring of code label Sep 23, 2024
@jkoenig134 jkoenig134 marked this pull request as ready for review September 23, 2024 11:03
Copy link

codecov bot commented Sep 23, 2024

@Magnus-Kuhn
Copy link
Contributor

The controllers TokenController etc. could also drop some loading methods or change them to private, but I don't think it's necessary and it would mean having to change tests

@jkoenig134
Copy link
Member Author

The controllers TokenController etc. could also drop some loading methods or change them to private, but I don't think it's necessary and it would mean having to change tests

yes, out of scope.

@Milena-Czierlinski
Copy link
Contributor

This will result in runtime@v6.

So what is the strategy for v6? Do we again collect breaking changes on a separate branch? Also, doesn't this PR then require the label breaking change?

@jkoenig134 jkoenig134 added the breaking-change A breaking change label Sep 23, 2024
@jkoenig134
Copy link
Member Author

jkoenig134 commented Sep 23, 2024

So what is the strategy for v6?

No strategy. Just release. We expect minimal to no impact by this change so no long-running communication needed.

@jkoenig134 jkoenig134 merged commit fd91803 into main Sep 23, 2024
17 checks passed
@jkoenig134 jkoenig134 deleted the refactor/remove-object-loading-by-id-and-key branch September 23, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change refactoring Refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants