Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing a request with yourself shows a misleading error message #280

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Sep 20, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Description

The error used to be: "There is no relationship to x".

@sebbi08 sebbi08 added the enhancement New feature or request label Sep 20, 2024
@sebbi08 sebbi08 changed the title Sharing a request with youself now shows a propper error message Sharing a request with yourself now shows a proper error message Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...es/requests/outgoing/OutgoingRequestsController.ts 60.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
...nsumption/src/consumption/ConsumptionCoreErrors.ts 80.34% <100.00%> (+0.22%) ⬆️
...es/requests/outgoing/OutgoingRequestsController.ts 83.49% <60.00%> (-0.29%) ⬇️

@Milena-Czierlinski
Copy link
Contributor

Also, if you want to be thorough you could add a test for this. ;)

@jkoenig134 jkoenig134 added bug Something isn't working and removed enhancement New feature or request labels Sep 20, 2024
@jkoenig134 jkoenig134 changed the title Sharing a request with yourself now shows a proper error message Sharing a request with yourself shows a misleading error message Sep 20, 2024
@jkoenig134
Copy link
Member

I am missing a test here.

jkoenig134
jkoenig134 previously approved these changes Sep 23, 2024
@sebbi08 sebbi08 merged commit 3ad1fa5 into main Sep 23, 2024
17 checks passed
@sebbi08 sebbi08 deleted the feature/improve_error_message_when_sharing_a_request_with_yourself branch September 23, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants