-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing a request with yourself shows a misleading error message #280
Merged
sebbi08
merged 7 commits into
main
from
feature/improve_error_message_when_sharing_a_request_with_yourself
Sep 23, 2024
Merged
Sharing a request with yourself shows a misleading error message #280
sebbi08
merged 7 commits into
main
from
feature/improve_error_message_when_sharing_a_request_with_yourself
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebbi08
changed the title
Sharing a request with youself now shows a propper error message
Sharing a request with yourself now shows a proper error message
Sep 20, 2024
Codecov ReportAttention: Patch coverage is
|
Also, if you want to be thorough you could add a test for this. ;) |
jkoenig134
added
bug
Something isn't working
and removed
enhancement
New feature or request
labels
Sep 20, 2024
jkoenig134
changed the title
Sharing a request with yourself now shows a proper error message
Sharing a request with yourself shows a misleading error message
Sep 20, 2024
jkoenig134
reviewed
Sep 20, 2024
packages/consumption/src/modules/requests/outgoing/OutgoingRequestsController.ts
Outdated
Show resolved
Hide resolved
I am missing a test here. |
jkoenig134
previously approved these changes
Sep 23, 2024
Milena-Czierlinski
requested changes
Sep 23, 2024
Milena-Czierlinski
approved these changes
Sep 23, 2024
sebbi08
deleted the
feature/improve_error_message_when_sharing_a_request_with_yourself
branch
September 23, 2024 07:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
The error used to be: "There is no relationship to x".