Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the message of "error.consumption.validation.inheritedFromItem" when using canCreate #271

Merged
merged 9 commits into from
Sep 18, 2024

Conversation

RuthDiG
Copy link
Contributor

@RuthDiG RuthDiG commented Sep 13, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@RuthDiG RuthDiG added wip Work in Progress (blocks mergify from auto update the branch) refactoring Refactoring of code labels Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...es/requests/outgoing/OutgoingRequestsController.ts 16.66% 5 Missing ⚠️
Files with missing lines Coverage Δ
...nsumption/src/consumption/ConsumptionCoreErrors.ts 80.11% <100.00%> (+0.23%) ⬆️
...consumption/src/modules/common/ValidationResult.ts 100.00% <100.00%> (ø)
...es/requests/outgoing/OutgoingRequestsController.ts 83.77% <16.66%> (-1.02%) ⬇️

@RuthDiG RuthDiG marked this pull request as ready for review September 17, 2024 07:30
@jkoenig134 jkoenig134 removed the wip Work in Progress (blocks mergify from auto update the branch) label Sep 17, 2024
@RuthDiG RuthDiG merged commit a65b798 into main Sep 18, 2024
17 checks passed
@RuthDiG RuthDiG deleted the bugfix/change-errorMessage-of-CanCreate branch September 18, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants