-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Personalized RelationshipTemplates #270
Conversation
This PR has no changes to the reference, so there's no runtime validation when loading a template with the truncated reference. |
we should introduce the change to the reference in an earlier PR and not merge this or #249 before. I'd suggest to make this a draft again until we figured out what we do with truncated references. |
packages/runtime/src/useCases/transport/relationshipTemplates/LoadPeerRelationshipTemplate.ts
Outdated
Show resolved
Hide resolved
...untime/src/useCases/transport/relationshipTemplates/CreateTokenForOwnRelationshipTemplate.ts
Show resolved
Hide resolved
packages/runtime/test/dataViews/RelationshipTemplateDVO.test.ts
Outdated
Show resolved
Hide resolved
packages/transport/test/modules/relationshipTemplates/RelationshipTemplateController.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@stnmtz you are blocking this PR 'case you have changes requested. Any addition to comments you had? |
Readiness checklist