Skip to content

Commit

Permalink
Remove WithStack and WithMessage public functions
Browse files Browse the repository at this point in the history
The refactoring to use withStack and withMessage types is useful enough
to land indepdently of exposing these helpers publically.
  • Loading branch information
davecheney committed Aug 8, 2016
1 parent 777ed74 commit 1b876e0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 26 deletions.
24 changes: 0 additions & 24 deletions errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,18 +132,6 @@ func (f *fundamental) Format(s fmt.State, verb rune) {
}
}

// WithStack annotates err with a stack trace at the point WithStack was called.
// If err is nil, WithStack returns nil.
func WithStack(err error) error {
if err == nil {
return nil
}
return &withStack{
err,
callers(),
}
}

type withStack struct {
error
*stack
Expand Down Expand Up @@ -205,18 +193,6 @@ func Wrapf(err error, format string, args ...interface{}) error {
}
}

// WithMessage annotates err with a new message.
// If err is nil, WithStack returns nil.
func WithMessage(err error, message string) error {
if err == nil {
return nil
}
return &withMessage{
cause: err,
msg: message,
}
}

type withMessage struct {
cause error
msg string
Expand Down
4 changes: 2 additions & 2 deletions stack_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,12 @@ func TestTrimGOPATH(t *testing.T) {
"github.com/pkg/errors/stack_test.go",
}}

for _, tt := range tests {
for i, tt := range tests {
pc := tt.Frame.pc()
fn := runtime.FuncForPC(pc)
file, _ := fn.FileLine(pc)
got := trimGOPATH(fn.Name(), file)
testFormatRegexp(t, got, "%s", tt.want)
testFormatRegexp(t, i, got, "%s", tt.want)
}
}

Expand Down

0 comments on commit 1b876e0

Please sign in to comment.