Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when floating point numbers are present in batch #340

Conversation

pbashyal-nmdp
Copy link
Contributor

Correctly marks as a failure for invalid serology.

Using config file: conf.json
Column:R_A_TYP1 =>
	A*02:01 => A*02:01
Column:R_A_TYP2 =>
	A*02:01 => A*02:01
Column:R_B_TYP1 =>
	B*13:02 => B*13:02
Column:R_B_TYP2 =>
	B*50:01:00 => B*50:01
Column:R_C_TYP1 =>
	C*06:02 => C*06:02
Column:R_C_TYP2 =>
	C*06:02 => C*06:02
Column:R_DRB1_TYP1 =>
	DRB1*07:01 => DRB1*07:01
Column:R_DRB1_TYP2 =>
	DRB1*13:01 => DRB1*13:01
Column:R_DQB1_TYP1 =>
	DQB1*02:02 => DQB1*02:01
Column:R_DQB1_TYP2 =>
Failed reducing '0.478472222' in column R_DQB1_TYP2
Summary
-------
1 alleles failed to reduce.
| Column  Name    |      Allele      |      Did you mean ?       
| --------------- | ---------------- | ------------------------- 
| R_DQB1_TYP2     | 0.478472222      | NA 
Saved result to file:data/test.gl.csv.gz

Fixes #339

@pbashyal-nmdp pbashyal-nmdp added the bug Something isn't working label Jan 15, 2025
@pbashyal-nmdp pbashyal-nmdp self-assigned this Jan 15, 2025
@mmaiers-nmdp mmaiers-nmdp merged commit 965d409 into nmdp-bioinformatics:master Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyard-reduce-csv doesn't validate
2 participants