Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

Added some prints to see which column is causing the issue #40

Conversation

mattfidler
Copy link
Member

No description provided.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.99%. Comparing base (25fae15) to head (8b4a88e).

Files Patch % Lines
src/et.cpp 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   62.16%   62.99%   +0.83%     
==========================================
  Files          21       21              
  Lines        4028     4035       +7     
==========================================
+ Hits         2504     2542      +38     
+ Misses       1524     1493      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattfidler mattfidler merged commit 9d90d77 into main Apr 5, 2024
7 of 8 checks passed
@mattfidler mattfidler deleted the 39-model-with-est-=-rxsolve-crashes-r-with-est-=-focei-works-fine branch April 5, 2024 23:31
@billdenney
Copy link
Contributor

What was the underlying issue? It seems like it was something about NA time, but I know that there were already checks for that, so it must have been something more specific, I guess.

@mattfidler
Copy link
Member Author

It was na time in the importing of event tables which was not handled.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model with est = "rxSolve" crashes R; with est = "focei" works fine
2 participants