-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tmdd model functions #60
base: main
Are you sure you want to change the base?
Conversation
…r2lib into TMDD-model-functions
…r2lib into TMDD-model-functions
@iamstein would you mind reviewing this. |
@kiranmayi3595 if you could make sure every parameter has a label, I think that would be helpful. I noticed that some of the models have empty labels ("") |
Also, it seems there are 1 and 2 compartment solutions. There should be only one compartment solutions with the We may re-align about the naming conventions later. |
We should also change the elimination throughout to be |
@kiranmayi3595 I am happy do these changes myself. |
For the compartment names too, for consistency I think we'd want something like: |
Hi @mattfidler and @iamstein , thank you for your comments. I will make these changes and update the models. |
Hi @kiranmayi3595. I'd recommended starting with just 4 models (parameterised by CL)as it might be the library could just consist of 4 and then the user could make additional modifications to get the other parameterizations. Andy |
This does not use the correct compartment names for the ODEs; it probably needs to be redone because of this... |
As there appear to be open issues here, I'm not yet merging these models for the upcoming release. Please let me know when they are ready to merge. |
No description provided.