Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmdd model functions #60

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Tmdd model functions #60

wants to merge 27 commits into from

Conversation

mattfidler
Copy link
Member

No description provided.

@mattfidler
Copy link
Member Author

@iamstein would you mind reviewing this.

@mattfidler
Copy link
Member Author

@kiranmayi3595 if you could make sure every parameter has a label, I think that would be helpful. I noticed that some of the models have empty labels ("")

@mattfidler
Copy link
Member Author

Also, it seems there are 1 and 2 compartment solutions. There should be only one compartment solutions with the Cl parametrization variant.

We may re-align about the naming conventions later.

@mattfidler
Copy link
Member Author

We should also change the elimination throughout to be kel so that a parametric transformation function could be applied each model to re-parameterize as the modeler sees fit.

@mattfidler
Copy link
Member Author

@kiranmayi3595 I am happy do these changes myself.

@iamstein
Copy link

For the compartment names too, for consistency I think we'd want something like:
central
peripheral
target (formerly T)
complex (formerly DT)
total_drug (formerly Dtot)
total_target (formerly Ttot)

@kiranmayi3595
Copy link
Contributor

Hi @mattfidler and @iamstein , thank you for your comments. I will make these changes and update the models.

@iamstein
Copy link

Hi @kiranmayi3595. I'd recommended starting with just 4 models (parameterised by CL)as it might be the library could just consist of 4 and then the user could make additional modifications to get the other parameterizations.

Andy

@mattfidler
Copy link
Member Author

This does not use the correct compartment names for the ODEs; it probably needs to be redone because of this...

@billdenney
Copy link
Contributor

As there appear to be open issues here, I'm not yet merging these models for the upcoming release. Please let me know when they are ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants